Add new Tier-3 target: loongarch64-unknown-linux-ohos
#130750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
This comment has been minimized.
This comment has been minimized.
heiher
force-pushed
the
loong-linux-ohos-tier3
branch
from
1478a18
to
8a0c305
Compare
This comment has been minimized.
This comment has been minimized.
heiher
force-pushed
the
loong-linux-ohos-tier3
branch
from
8a0c305
to
4f2704a
Compare
This comment has been minimized.
This comment has been minimized.
heiher
force-pushed
the
loong-linux-ohos-tier3
branch
from
4f2704a
to
5d591c6
Compare
jieyouxu
approved these changes
Sep 23, 2024
jieyouxu
added
S-waiting-on-author
heiher
force-pushed
the
loong-linux-ohos-tier3
branch
from
5d591c6
to
9ab7046
Compare
MCP: rust-lang/compiler-team#784 Co-authored-by: WANG Rui <wangrui@loongson.cn>
|
@rustbot ready |
rustbot
added
S-waiting-on-review
jieyouxu
approved these changes
Sep 23, 2024
This comment was marked as outdated.
This comment was marked as outdated.
|
Actually wait, has the MCP finished? Or should this be |
jieyouxu
added
S-waiting-on-MCP
The FCP 10-day waiting period is up. Could you label it as accepted? |
|
Oh, is it just that rustbot is not responding for whatever reason. |
|
@bors r+ rollup |
bors
added
the
S-waiting-on-bors
jieyouxu
added
O-loongarch
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Sep 24, 2024
…ieyouxu Add new Tier-3 target: `loongarch64-unknown-linux-ohos` MCP: rust-lang/compiler-team#784
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2024
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#129545 (rustdoc: redesign toolbar and disclosure widgets) - rust-lang#130618 (Skip query in get_parent_item when possible.) - rust-lang#130727 (Check vtable projections for validity in miri) - rust-lang#130739 (Pass bootstrap cargo when `--stage 0` and `COMPILETEST_FORCE_STAGE0`) - rust-lang#130750 (Add new Tier-3 target: `loongarch64-unknown-linux-ohos`) - rust-lang#130758 (Revert "Add recursion limit to FFI safety lint") - rust-lang#130759 (Update books) - rust-lang#130762 (stabilize const_intrinsic_copy) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2024
…mpiler-errors Rollup of 7 pull requests Successful merges: - rust-lang#129545 (rustdoc: redesign toolbar and disclosure widgets) - rust-lang#130618 (Skip query in get_parent_item when possible.) - rust-lang#130727 (Check vtable projections for validity in miri) - rust-lang#130750 (Add new Tier-3 target: `loongarch64-unknown-linux-ohos`) - rust-lang#130758 (Revert "Add recursion limit to FFI safety lint") - rust-lang#130759 (Update books) - rust-lang#130762 (stabilize const_intrinsic_copy) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 24, 2024
Rollup merge of rust-lang#130750 - heiher:loong-linux-ohos-tier3, r=jieyouxu Add new Tier-3 target: `loongarch64-unknown-linux-ohos` MCP: rust-lang/compiler-team#784
DianQK
reviewed
Sep 25, 2024
|
|
||
| pub(crate) fn target() -> Target { | ||
| Target { | ||
| // LLVM 15 doesn't support OpenHarmony yet, use a linux target instead. |
There was a problem hiding this comment.
Question: why does here currently still support for LLVM 15 when the minimum supported version is LLVM 18?
There was a problem hiding this comment.
This line is copied from the aarch64-unknown-linux-ohos target. The ohos triple has been supported since LLVM 17, so it's time to update it. #130809
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MCP: rust-lang/compiler-team#784