Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[experiment] Update cc CI tests #130908

Closed
wants to merge 7 commits into from
Closed

[experiment] Update cc CI tests #130908

wants to merge 7 commits into from

Conversation

tgross35
Copy link
Contributor

See #130720, #130898; try with the minimal version bump.

try-job: x86_64-msvc

@tgross35 tgross35 changed the title Update cc to 1.0.100 [experiment] Update cc to 1.0.100 Sep 26, 2024
@rustbot
Copy link
Collaborator

rustbot commented Sep 26, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 26, 2024
@tgross35
Copy link
Contributor Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 26, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
f42fb94 
[experiment] Update cc to 1.0.100

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Sep 26, 2024

⌛ Trying commit 68bb7cb with merge f42fb94...

This was referenced Sep 26, 2024
Closed
Merged
@bors
Copy link
Contributor

bors commented Sep 27, 2024

☀️ Try build successful - checks-actions
Build commit: f42fb94 (f42fb94e330f6efa99e6f1acc7103fc3b2b8a957)

@tgross35
Copy link
Contributor Author

Woah! So it succeeded with 1.0.100, let's try the next one up.

@tgross35
Copy link
Contributor Author

@bors try

@bors
Copy link
Contributor

bors commented Sep 27, 2024

⌛ Trying commit 09e43e6 with merge 9d55780...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
9d55780 
[experiment] Update cc to 1.0.100

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
@tgross35
Copy link
Contributor Author

Probably should have done more of a bisect algorithm, since we have (now) a known good at 1.0.100 and a known bad at 1.0.106. Updated to 1.0.103, I think the first job will still continue

@bors try

@bors
Copy link
Contributor

bors commented Sep 27, 2024

⌛ Trying commit e52d2be with merge ed664a2...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
ed664a2 
[experiment] Update cc to 1.0.100

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
@tgross35
Copy link
Contributor Author

1.0.105 and 1.0.106 both have windows changes, so those seem like likely candidates https://github.com/rust-lang/cc-rs/releases/tag/cc-v1.0.105 https://github.com/rust-lang/cc-rs/releases/tag/cc-v1.0.106. I guess if try jobs work in parallel, might as well make use of that.

@bors try (for 1.0.104)

@bors
Copy link
Contributor

bors commented Sep 27, 2024

⌛ Trying commit d5f2e5d with merge f1d03b0...

@tgross35 tgross35 changed the title [experiment] Update cc to 1.0.100 [experiment] Update cc CI tests Sep 27, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
f1d03b0 
[experiment] Update cc to 1.0.100

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
@tgross35
Copy link
Contributor Author

@bors try (for 1.0.105)

@bors
Copy link
Contributor

bors commented Sep 27, 2024

⌛ Trying commit a39a92e with merge 3bfb192...

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
3bfb192 
[experiment] Update `cc` CI tests

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tgross35 tgross35 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 27, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors
Copy link
Contributor

bors commented Sep 27, 2024

💔 Test failed - checks-actions

@bors bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 27, 2024
@tgross35
Copy link
Contributor Author

tgross35 commented Sep 27, 2024 •
edited
Loading

So we have:

All of the failures were around the 1 hour mark, failure to build compiler_builtins or one of its dependencies.

The changes between 1.0.100 and 1.0.101 did adjust the way that some tools are found on Windows, maybe the update causes different versions to be located? That may also make a caching difference rust-lang/cc-rs@cc-v1.0.100...cc-v1.0.101

These results don't feel very concrete so I'll rerun 100/101 to see if they appear consistent.

@tgross35
Copy link
Contributor Author

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
61e52cc 
[experiment] Update `cc` CI tests

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Sep 27, 2024

⌛ Trying commit a4a9132 with merge 61e52cc...

@bors
Copy link
Contributor

bors commented Sep 27, 2024

☀️ Try build successful - checks-actions
Build commit: 61e52cc (61e52cc147711272b56080e36c3e34373508b0a6)

@arttet
Copy link
Contributor

arttet commented Sep 27, 2024

I think this commit is suspicious. I would like to try without it.

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Sep 27, 2024
@tgross35
Copy link
Contributor Author

Trying with 1.1.22, which includes @ChrisDenton's fix rust-lang/cc-rs#1215

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 27, 2024
@bors
Auto merge of rust-lang#130908 - tgross35:update-cc, r=<try>
d82723e 
[experiment] Update `cc` CI tests

See rust-lang#130720, rust-lang#130898; try with the minimal version bump.

try-job: x86_64-msvc
@bors
Copy link
Contributor

bors commented Sep 27, 2024

⌛ Trying commit 3c840fd with merge d82723e...

@arttet
Copy link
Contributor

arttet commented Sep 27, 2024

It looks like that fix works.

@tgross35
Copy link
Contributor Author

It looks like that fix works.

Did it pass somewhere? It looks like the try jobs here and in #130926 only got picked up 25 minutes ago

@arttet
Copy link
Contributor

arttet commented Sep 27, 2024

The job has built profiler_builtins. But let's wait for results.

@tgross35
Copy link
Contributor Author

Everything gets built multiple times, the failures here have been around the 1 hour mark. Some of the MSVC issues are closer to the end though.

@bors
Copy link
Contributor

bors commented Sep 27, 2024

☀️ Try build successful - checks-actions
Build commit: d82723e (d82723e909d1f23e9ed74ce0c81e05e7a3bcc694)

@tgross35
Copy link
Contributor Author

Cool, Chris has the update covered in #130926 (comment)

@tgross35 tgross35 closed this Sep 27, 2024
@tgross35 tgross35 deleted the update-cc branch September 27, 2024 13:38
@tgross35 tgross35 mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tgross35 @rustbot @bors @rust-log-analyzer @arttet @Mark-Simulacrum