Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crashes: more tests #130975

Merged
merged 1 commit into from
Sep 29, 2024
Merged

Conversation

matthiaskrgr
Copy link
Member

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 28, 2024
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Member

r=me after CI is green

@jieyouxu
Copy link
Member

@bors r+ rollup=iffy (crashes test)

@bors
Copy link
Contributor

bors commented Sep 28, 2024

📌 Commit fa4816b has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 28, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 28, 2024
… r=jieyouxu

crashes: more tests

r? `@jieyouxu`
@bors
Copy link
Contributor

bors commented Sep 28, 2024

⌛ Testing commit fa4816b with merge 6eef6a0...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Sep 28, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 28, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Sep 28, 2024

I feel like #130687 is not a great crashes test, it probably wants its own decision about what to do in const-eval OOM situations and a dedicated test for whatever behavior is determined reasonable. I recommend removing this crashes test. r=me once you remove that test.

@matthiaskrgr
Copy link
Member Author

marked the test as //@ only-x86_64
@rustbot ready

@jieyouxu
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Sep 29, 2024

📌 Commit 6d3aee2 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2024
@bors
Copy link
Contributor

bors commented Sep 29, 2024

⌛ Testing commit 6d3aee2 with merge d194948...

@bors
Copy link
Contributor

bors commented Sep 29, 2024

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing d194948 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 29, 2024
@bors bors merged commit d194948 into rust-lang:master Sep 29, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 29, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d194948): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.5% [-3.5%, -3.5%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.3%, secondary 1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.3% [1.0%, 1.5%] 7
Regressions ❌
(secondary)
1.5% [1.5%, 1.5%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.3% [1.0%, 1.5%] 7

Cycles

Results (secondary -2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.2%, 2.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.6% [-3.9%, -3.2%] 6
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 768.779s -> 767.592s (-0.15%)
Artifact size: 341.41 MiB -> 341.37 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants