-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crashes: more tests #130975
crashes: more tests #130975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
r=me after CI is green |
@bors r+ rollup=iffy (crashes test) |
… r=jieyouxu crashes: more tests r? `@jieyouxu`
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
I feel like #130687 is not a great crashes test, it probably wants its own decision about what to do in const-eval OOM situations and a dedicated test for whatever behavior is determined reasonable. I recommend removing this crashes test. r=me once you remove that test. |
fa4816b
to
6d3aee2
Compare
marked the test as |
@bors r+ |
☀️ Test successful - checks-actions |
Finished benchmarking commit (d194948): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)Results (primary 1.3%, secondary 1.5%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary -2.8%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 768.779s -> 767.592s (-0.15%) |
r? @jieyouxu