Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add clarity for custom path installation #131001

Merged

Conversation

iyernaveenr
Copy link
Contributor

install.sysconfdir is another value, in addition to install.prefix, that could be set for custom path installation.

@rustbot
Copy link
Collaborator

rustbot commented Sep 29, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2024
@iyernaveenr iyernaveenr force-pushed the naveen_iyer/installation_clarity branch from cd2aab6 to e69c242 Compare September 29, 2024 02:20
@jieyouxu jieyouxu added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 29, 2024
INSTALL.md Outdated Show resolved Hide resolved
@iyernaveenr iyernaveenr force-pushed the naveen_iyer/installation_clarity branch 3 times, most recently from 8a7a03a to a05938f Compare October 1, 2024 01:20
INSTALL.md Outdated Show resolved Hide resolved
install.sysconfdir is another value, in addition to install.prefix,
that could be set for custom path installation.

Signed-off-by: Naveen R. Iyer <iyernaveenr@gmail.com>
@onur-ozkan
Copy link
Member

Thanks!

@bors r+

@bors
Copy link
Contributor

bors commented Oct 6, 2024

📌 Commit 0df736c has been approved by onur-ozkan

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 6, 2024
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#131001 (add clarity for custom path installation)
 - rust-lang#131307 (Android: Debug assertion after setting thread name)
 - rust-lang#131322 (Update out-dated link)
 - rust-lang#131335 (grammar fix)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 1e2b77d into rust-lang:master Oct 6, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 6, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 6, 2024
Rollup merge of rust-lang#131001 - iyernaveenr:naveen_iyer/installation_clarity, r=onur-ozkan

add clarity for custom path installation

install.sysconfdir is another value, in addition to install.prefix, that could be set for custom path installation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants