Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup: don't manually unwrap_or_default() #131013

Merged
merged 1 commit into from
Sep 29, 2024
Merged

cleanup: don't manually unwrap_or_default() #131013

merged 1 commit into from
Sep 29, 2024

Conversation

matthiaskrgr
Copy link
Member

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Sep 29, 2024

r? @michaelwoerister

rustbot has assigned @michaelwoerister.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 29, 2024
jieyouxu
jieyouxu approved these changes Sep 29, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me once PR CI is green.

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Sep 29, 2024

📌 Commit 1a28599 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 29, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 29, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 29, 2024
@bors
Auto merge of rust-lang#131022 - matthiaskrgr:rollup-g9y1v11, r=matth…
42ff2ee 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#130931 (Rename `standalone` doctest attribute into `standalone_crate`)
 - rust-lang#131000 (Weekly `cargo update`)
 - rust-lang#131011 (cleanup: don't `.into()` identical types)
 - rust-lang#131013 (cleanup: don't manually `unwrap_or_default()`)
 - rust-lang#131014 (cleanup: don't clone types that are Copy)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit af1e24b into rust-lang:master Sep 29, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Sep 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Sep 29, 2024
@rust-timer
Unrolled build for rust-lang#131013
5c43e5a 
Rollup merge of rust-lang#131013 - matthiaskrgr:unwrapordefault, r=jieyouxu

cleanup: don't manually `unwrap_or_default()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@matthiaskrgr @rustbot @jieyouxu @bors @michaelwoerister