Fix target_abi in sparc-unknown-none-elf
#131174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
These commits modify compiler targets. |
|
Noting rust-lang/compiler-team#716 |
This comment has been minimized.
This comment has been minimized.
madsmtm
force-pushed
the
target-info-sparc-abi
branch
from
eb33df8
to
734594c
Compare
|
I mean, sure, but the target is still broken thanks to symbol.o having the wrong CPU architecture, isn't it? |
Don't know anything about that (or the target, for that matter), just opened this PR to fix the inconsistency in |
pnkfelix
reviewed
Oct 4, 2024
compiler/rustc_target/src/spec/targets/sparc_unknown_none_elf.rs
Outdated
Show resolved
Hide resolved
|
@rustbot author |
rustbot
added
S-waiting-on-author
|
(r=me once above change has been made) |
This was previously set to `target_abi = "elf"`, but `elf` is not used elsewhere as a target ABI (even though there's many targets that have it in their name).
madsmtm
force-pushed
the
target-info-sparc-abi
branch
from
734594c
to
f51d8e3
Compare
|
Some changes occurred in tests/ui/check-cfg cc @Urgau |
|
Done now, thanks for the review |
rustbot
added
S-waiting-on-review
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Oct 4, 2024
…nkfelix Fix `target_abi` in `sparc-unknown-none-elf` This was previously set to `target_abi = "elf"`, but `elf` is not used elsewhere as a target ABI (even though there's many targets that have it in their name), so I've removed it. CC target maintainer `@jonathanpallant,` what do you think about this? `@rustbot` label O-SPARC
This was referenced Oct 4, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 4, 2024
…kingjubilee Rollup of 10 pull requests Successful merges: - rust-lang#130453 (Add x86_64-unknown-trusty as tier 3 target) - rust-lang#130518 (Stabilize the `map`/`value` methods on `ControlFlow`) - rust-lang#131116 (Increase Stack Size for AIX) - rust-lang#131171 (Fix `target_env` in `avr-unknown-gnu-atmega328`) - rust-lang#131174 (Fix `target_abi` in `sparc-unknown-none-elf`) - rust-lang#131177 ( Stabilize 5 `const_mut_refs`-dependent API) - rust-lang#131238 (Remove mw from triagebot.toml) - rust-lang#131240 (Fix typo in csky-unknown-linux-gnuabiv2.md) - rust-lang#131257 ([rustdoc] Fix list margins) - rust-lang#131264 (Fix some `pub(crate)` that were undetected bc of `#[instrument]`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 5, 2024
Rollup merge of rust-lang#131174 - madsmtm:target-info-sparc-abi, r=pnkfelix Fix `target_abi` in `sparc-unknown-none-elf` This was previously set to `target_abi = "elf"`, but `elf` is not used elsewhere as a target ABI (even though there's many targets that have it in their name), so I've removed it. CC target maintainer ``@jonathanpallant,`` what do you think about this? ``@rustbot`` label O-SPARC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously set to
target_abi = "elf", butelfis not used elsewhere as a target ABI (even though there's many targets that have it in their name), so I've removed it.CC target maintainer @jonathanpallant, what do you think about this?
@rustbot label O-SPARC