Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: aarch64-gnu-debug job #131207

Merged
merged 2 commits into from
Oct 25, 2024
Merged

ci: aarch64-gnu-debug job #131207

merged 2 commits into from
Oct 25, 2024

Conversation

davidtwco
Copy link
Member

@davidtwco davidtwco commented Oct 3, 2024 •
edited by tgross35
Loading

  • Adds a new CI job which checks that the compiler builds with --enable-debug and tests that needs-force-clang-based-tests pass (where cross-language LTO is tested).
  • Add a test confirming that -Zbranch-protection=pac-ret and cross-language LTO work together.

r? @Mark-Simulacrum

try-job: aarch64-gnu-debug

@rustbot rustbot added A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 3, 2024
@rustbot

This comment was marked as off-topic.

Sign in to view
@jieyouxu jieyouxu mentioned this pull request Oct 3, 2024
Merged
jieyouxu
jieyouxu approved these changes Oct 3, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test itself LGTM

@Mark-Simulacrum
Copy link
Member

@bors r+

This seems OK to me.

@bors
Copy link
Contributor

bors commented Oct 12, 2024

📌 Commit bb0a461 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2024
tgross35 added a commit to tgross35/rust that referenced this pull request Oct 12, 2024
@tgross35
Rollup merge of rust-lang#131207 - davidtwco:pac-ret-lto-test, r=Mark…
b2fc151 
…-Simulacrum

ci: aarch64-gnu-debug job

- Adds a new CI job which checks that the compiler builds with `--enable-debug` and tests that `needs-force-clang-based-tests` pass (where cross-language LTO is tested).
- Add a test confirming that `-Zbranch-protection=pac-ret` and cross-language LTO work together.

r? `@Mark-Simulacrum`
@tgross35 tgross35 mentioned this pull request Oct 12, 2024
Closed
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2024
@bors
Auto merge of rust-lang#131630 - tgross35:rollup-2feqbwv, r=tgross35
0c3a4ea 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#131120 (Stabilize `const_option`)
 - rust-lang#131207 (ci: aarch64-gnu-debug job)
 - rust-lang#131334 (Enable sanitizers for loongarch64-unknown-*)
 - rust-lang#131358 (force "HEAD" for non-CI and `git_upstream_merge_base` for CI environment)
 - rust-lang#131418 (Use throw intrinsic from stdarch in wasm libunwind)
 - rust-lang#131579 (Remap path prefix in the panic message of `tests/ui/meta/revision-bad.rs`)
 - rust-lang#131591 (add latest crash tests)

r? `@ghost`
`@rustbot` modify labels: rollup
@tgross35
Copy link
Contributor

Do we have a limit on the number of runners that handle arm jobs? The auto job is about an hour in and https://github.com/rust-lang-ci/rust/actions/runs/11309982802/job/31454499991 still says "Job is waiting for a runner from 'ubuntu-22.04-arm64-8core-32gb' to come online." for the existing aarch64-gnu job.

@tgross35
Copy link
Contributor

tgross35 commented Oct 13, 2024 •
edited
Loading

Looks like this failed the rollup #131630 (comment).

@bors r-

Regarding my above message - the original aarch64-gnu job did eventually start, just about an hour later than everything else.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 13, 2024
@davidtwco
Copy link
Member Author

@Mark-Simulacrum do you know whether we do have a limit on these runners or why it would be slow to start?

@Mark-Simulacrum
Copy link
Member

There should be 50(?) runners worth of concurrency of this particular runner, so I doubt that was the problem. Looking back it looks like the job did eventually run, maybe this was fallout from the github problems last week (IIRC)?

I'd suggest we just retry.

@davidtwco
Copy link
Member Author

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Oct 15, 2024

📌 Commit bb0a461 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 15, 2024
@tgross35
Copy link
Contributor

Did something land to fix the cross-lang-lto failure on this job from the rollup?

@jieyouxu
Copy link
Member

FTR, the failure was

call.*rust_never_inlined
thread 'main' panicked at /checkout/tests/run-make/cross-lang-lto-clang/rmake.rs:41:10:
needle was not found in haystack

@jieyouxu
Copy link
Member

jieyouxu commented Oct 15, 2024 •
edited
Loading

That test was previously only ever exercised on the x86_64-debug counterpart, so presumably that is still going to fail. If some cases need to be arch specific, they'll need to be guarded by #[cfg(target_arch = "...")] since run-make tests don't (currently) support revisions.
@bors r-

@bors bors removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 15, 2024
@jieyouxu jieyouxu mentioned this pull request Oct 22, 2024
Open
2 tasks
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@davidtwco
Copy link
Member Author

Oops, had a uncommitted chunk locally, should all pass now.

@davidtwco
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 23, 2024

⌛ Trying commit 4902231 with merge 5cafc36...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 23, 2024
@bors
Auto merge of rust-lang#131207 - davidtwco:pac-ret-lto-test, r=<try>
5cafc36 
ci: aarch64-gnu-debug job

- Adds a new CI job which checks that the compiler builds with `--enable-debug` and tests that `needs-force-clang-based-tests` pass (where cross-language LTO is tested).
- Add a test confirming that `-Zbranch-protection=pac-ret` and cross-language LTO work together.

r? `@Mark-Simulacrum`

try-job: aarch64-gnu-debug
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

This comment was marked as resolved.

Sign in to view
@davidtwco
ci: add aarch64-gnu-debug job
105961e 
Adds a new CI job which checks that the compiler builds with
`--enable-debug` and tests that `needs-force-clang-based-tests` pass
(where cross-language LTO is tested).
@davidtwco
tests: add pac-ret + cross-language lto test
352b505 
Add a test confirming that `-Zbranch-protection=pac-ret` and
cross-language LTO work together.
@davidtwco
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 25, 2024

⌛ Trying commit 352b505 with merge 7fef711...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 25, 2024
@bors
Auto merge of rust-lang#131207 - davidtwco:pac-ret-lto-test, r=<try>
7fef711 
ci: aarch64-gnu-debug job

- Adds a new CI job which checks that the compiler builds with `--enable-debug` and tests that `needs-force-clang-based-tests` pass (where cross-language LTO is tested).
- Add a test confirming that `-Zbranch-protection=pac-ret` and cross-language LTO work together.

r? `@Mark-Simulacrum`

try-job: aarch64-gnu-debug
@bors
Copy link
Contributor

bors commented Oct 25, 2024

☀️ Try build successful - checks-actions
Build commit: 7fef711 (7fef7111b4abb95dd6ab582926cff4ac72b43a3e)

@davidtwco
Copy link
Member Author

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Oct 25, 2024

📌 Commit 352b505 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 25, 2024
@bors
Copy link
Contributor

bors commented Oct 25, 2024

⌛ Testing commit 352b505 with merge 45089ec...

@bors
Copy link
Contributor

bors commented Oct 25, 2024

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 45089ec to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 25, 2024
@bors bors merged commit 45089ec into rust-lang:master Oct 25, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 25, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (45089ec): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.9%, secondary 3.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 0.9% [0.9%, 0.9%] 1
Regressions ❌
(secondary)		 3.0% [2.0%, 3.9%] 2
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) 0.9% [0.9%, 0.9%] 1

Cycles

Results (secondary 2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 - - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 785.686s -> 790.301s (0.59%)
Artifact size: 333.72 MiB -> 333.71 MiB (-0.00%)

@davidtwco davidtwco deleted the pac-ret-lto-test branch October 28, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-run-make Area: port run-make Makefiles to rmake.rs A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.84.0
Development

Successfully merging this pull request may close these issues.
8 participants
@davidtwco @rustbot @Mark-Simulacrum @bors @tgross35 @jieyouxu @rust-log-analyzer @rust-timer