-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce SolverRelating type relation to the new solver #131263
Conversation
changes to the core type system |
3c2a620
to
d543f4e
Compare
This comment has been minimized.
This comment has been minimized.
d543f4e
to
09afb0f
Compare
This comment has been minimized.
This comment has been minimized.
09afb0f
to
bac2557
Compare
We could also, perhaps, get rid of |
☔ The latest upstream changes (presumably #131226) made this pull request unmergeable. Please resolve the merge conflicts. |
…s, r=<try> Remove `CombineFields` This conflicts with rust-lang#131263, but if this one lands first then perhaps rust-lang#131263 could then go ahead and remove all the branching on solver in `TypeRelating`. We could perhaps then rename `TypeRelating` to `OldSolverRelating` or something, idk. r? lcnr
5fa0570
to
7ac5804
Compare
This comment has been minimized.
This comment has been minimized.
7ac5804
to
747a3c6
Compare
This comment has been minimized.
This comment has been minimized.
747a3c6
to
6673e4a
Compare
…s, r=lcnr Remove `CombineFields` This conflicts with rust-lang#131263, but if this one lands first then perhaps rust-lang#131263 could then go ahead and remove all the branching on solver in `TypeRelating`. We could perhaps then rename `TypeRelating` to `OldSolverRelating` or something, idk. r? lcnr
…s, r=lcnr Remove `CombineFields` This conflicts with rust-lang#131263, but if this one lands first then perhaps rust-lang#131263 could then go ahead and remove all the branching on solver in `TypeRelating`. We could perhaps then rename `TypeRelating` to `OldSolverRelating` or something, idk. r? lcnr
Now that the other PR landed, I believe this is ready |
6673e4a
to
3fb3f4f
Compare
r=me after review |
3fb3f4f
to
8715bfb
Compare
@bors r+ rollup=never |
☀️ Test successful - checks-actions |
Finished benchmarking commit (8d94e06): comparison URL. Overall result: ❌ regressions - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps:
@rustbot label: +perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -1.2%, secondary -0.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (primary 0.7%, secondary -2.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 774.326s -> 779.131s (0.62%) |
Redux of #128744.
Splits out relate for the new solver so that implementors don't need to implement it themselves.
r? lcnr