Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler-builtins to 0.1.133 #131314

Merged
merged 1 commit into from
Oct 6, 2024
Merged

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Oct 6, 2024

This includes 1, which should help resolve an infinite recusion issue on WASM and SPARC (possibly other platforms). See 2 and 3 for further details.

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 6, 2024
@tgross35 tgross35 marked this pull request as ready for review October 6, 2024 02:38
@rustbot
Copy link
Collaborator

rustbot commented Oct 6, 2024

These commits modify the library/Cargo.lock file. Unintentional changes to library/Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@tgross35
Copy link
Contributor Author

tgross35 commented Oct 6, 2024

This contains a single commit that is no functionality change, just affects codegen rust-lang/compiler-builtins@727e350.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 6, 2024

📌 Commit 7c0c511 has been approved by tgross35

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2024
@tgross35
Copy link
Contributor Author

tgross35 commented Oct 6, 2024

@bors rollup=iffy

@bors
Copy link
Contributor

bors commented Oct 6, 2024

⌛ Testing commit 7c0c511 with merge 7d53688...

@bors
Copy link
Contributor

bors commented Oct 6, 2024

☀️ Test successful - checks-actions
Approved by: tgross35
Pushing 7d53688 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 6, 2024
@bors bors merged commit 7d53688 into rust-lang:master Oct 6, 2024
7 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 6, 2024
@tgross35 tgross35 deleted the update-builtins branch October 6, 2024 09:12
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7d53688): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.4% [-0.4%, -0.4%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results (primary 1.5%, secondary 1.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.5% [1.5%, 1.5%] 1
Regressions ❌
(secondary)
1.5% [1.4%, 1.6%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.5% [1.5%, 1.5%] 1

Cycles

Results (primary 1.7%, secondary 2.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.7% [1.7%, 1.7%] 1
Regressions ❌
(secondary)
2.9% [2.9%, 2.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.7% [1.7%, 1.7%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.475s -> 774.957s (0.06%)
Artifact size: 329.52 MiB -> 329.49 MiB (-0.01%)

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2024
…=aDotInTheVoid

Update `compiler-builtins` to 0.1.134

I'm modeling this PR after rust-lang#131314.

This pulls in rust-lang/compiler-builtins#713 which should mitigate the problem reported and discussed in https://rust-lang.zulipchat.com/#narrow/channel/131828-t-compiler/topic/Hello.20World.20on.20sparc-unknown-none-elf.20crashes
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 19, 2024
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants