Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coverage: Multiple small tweaks to counter creation #131325

Merged
merged 3 commits into from
Oct 7, 2024
Merged

coverage: Multiple small tweaks to counter creation #131325

merged 3 commits into from
Oct 7, 2024

Commits on Oct 6, 2024

  1. coverage: Make BcbCounter module-private

    @Zalathar
    Zalathar committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    3f90bb1 View commit details
    Browse the repository at this point in the history

  2. coverage: Have MakeBcbCounters own its CoverageCounters

    @Zalathar
    Zalathar committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    c6e4fcd View commit details
    Browse the repository at this point in the history

  3. coverage: Store bcb_needs_counter in a field as a bitset 

    This makes it possible for other parts of counter-assignment to check whether a
node is guaranteed to end up with some kind of counter.

Switching from `impl Fn` to a concrete `&BitSet` just avoids the hassle of
trying to store a closure in a struct field, and currently there's no
foreseeable need for this information to not be a bitset.
    @Zalathar
    Zalathar committed Oct 6, 2024
    Configuration menu
    Copy the full SHA
    ab154e6 View commit details
    Browse the repository at this point in the history