Commits on Oct 10, 2024

1. Auto merge of rust-lang#13464 - y21:issue13458, r=flip1995 …

   Don't warn on proc macro generated code in `needless_return`
   
   Fixes rust-lang#13458
   Fixes rust-lang#13457
   Fixes rust-lang#13467
   Fixes rust-lang#13479
   Fixes rust-lang#13481
   Fixes rust-lang#13526
   Fixes rust-lang#13486
   
   The fix is unfortunately a little more convoluted than just simply adding a `is_from_proc_macro`. That check *does*  fix the issue, however it also introduces a bunch of false negatives in the tests, specifically when the returned expression is in a different syntax context, e.g. `return format!(..)`.
   
   The proc macro check builds up a start and end pattern based on the HIR nodes and compares it to a snippet of the span, however that would currently fail for `return format!(..)` because we would have the patterns `("return", <something inside of the format macro>)`, which doesn't compare equal. So we now return an empty string pattern for when it's in a different syntax context.
   
   "Hide whitespace" helps a bit for reviewing the proc macro detection change
   
   changelog: none

   

   bors authored and flip1995 committed Oct 10, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for a21a9fe
   • Browse repository at this point

   Copy the full SHA

   a21a9fe View commit details

   Browse the repository at this point in the history