More work on installers #13151
Merged
More work on installers #13151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit d621631. Conflicts: mk/install.mk
Trying to reduce the complexity of installation
This is not sufficient for finding the library directory for binary installs, but it does make the build more complex by requiring env vars be set to build rustc.
This adds a hack to rustc to make it find the library directory regardless of whether it is named lib/lib64/lib32.
|
Just confirming, but you've run a smoke-test of |
|
Travis failed in the previous run. I restarted the job just to make sure it was not a random failure (since the code seemed fine to me). |
The installed manifest is a different file, so they should have different names. This should prevent various wierd conflicts in the future.
|
There are still some bugs here: the handling of lib64 isn't quite right (it's not looking for rustlib - just assuming that if there's a lib64 dir it should be used); mac installation is completely broken. |
Instead of just looking for its presence we need to see if it actually contains rust stuffs.
|
I think it's ready. |
bors
added a commit
that referenced
this pull request
Mar 27, 2014
A variety of stuff here, mostly aimed at making `make install` work correctly with `--libdir` and `--mandir`. `make install` again goes through `install.sh`.
JohnTitor
pushed a commit
to JohnTitor/rust
that referenced
this pull request
Sep 6, 2022
…er-type, r=Veykril Use correct type in "Replace turbofish with type" And support `?` and `.await` expressions. Fixes rust-lang#13148. The assist can still show up even if the turbofish's type is not used at all, e.g.: ```rust fn foo<T>() {} let v = foo::<i32>(); ```
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Jul 25, 2024
Fix running compile-test under cargo nextest `ui_test` itself has `cargo nextest` support which we now use - oli-obk/ui_test#161 It prints `ui_test` as its test name whereas we printed `compile_test`, this ended up being treated as a test name filter causing all the tests to be filtered out changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A variety of stuff here, mostly aimed at making
make installwork correctly with--libdirand--mandir.make installagain goes throughinstall.sh.