Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark InterpResult as must_use #131596

Merged
merged 1 commit into from
Oct 12, 2024
Merged

mark InterpResult as must_use #131596

merged 1 commit into from
Oct 12, 2024

Conversation

RalfJung
Copy link
Member

This was forgotten in #130885

@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 12, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 12, 2024

Some changes occurred to the CTFE / Miri interpreter

cc @rust-lang/miri

jieyouxu
jieyouxu approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 12, 2024

📌 Commit 8962343 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 12, 2024
@jieyouxu jieyouxu assigned jieyouxu and unassigned davidtwco Oct 12, 2024
@tgross35 tgross35 mentioned this pull request Oct 12, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2024
@bors
Auto merge of rust-lang#131612 - tgross35:rollup-zy3yg4p, r=tgross35
6b9676b 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#130870 (Add suggestion for removing invalid path sep `::` in fn def)
 - rust-lang#130954 (Stabilize const `ptr::write*` and `mem::replace`)
 - rust-lang#131233 (std: fix stdout-before-main)
 - rust-lang#131590 (yeet some clones)
 - rust-lang#131596 (mark InterpResult as must_use)
 - rust-lang#131597 (Take a display name for `tool_check_step!`)
 - rust-lang#131605 (`LLVMConstInt` only allows integer types)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 421abc8 into rust-lang:master Oct 12, 2024
6 checks passed
@rustbot rustbot added this to the 1.83.0 milestone Oct 12, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 12, 2024
@rust-timer
Unrolled build for rust-lang#131596
c7eee2f 
Rollup merge of rust-lang#131596 - RalfJung:interp-result-must-use, r=jieyouxu

mark InterpResult as must_use

This was forgotten in rust-lang#130885
@RalfJung RalfJung deleted the interp-result-must-use branch October 13, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.83.0
Development

Successfully merging this pull request may close these issues.
5 participants
@RalfJung @rustbot @jieyouxu @bors @davidtwco