Register src/tools/unicode-table-generator as a runnable tool
#131647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bootstrap assumes that the binary name is the same as tool name, just makes everyone's lives easier.
rustbot
added
S-waiting-on-review
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
This comment was marked as resolved.
This comment was marked as resolved.
These comments were updated on master but not through this tool, so the comments in the tool became outdated. Sync the comments to stay consistent.
…` that it needs to be generated by tool And should not be directly edited.
rustbot
added
the
A-meta
|
|
|
580a634 added the test file. I don't really recall that, but poking around it looks likely that the intent was to produce it and then manually run e.g. re:tidy checking, I think it's likely to be expensive to re-run the tool - and probably incompatible with offline builds - but we could maybe commit a hash of the file to source code and use that as a signal of manual modification? FWIW historically this was just run from the directory (e.g., cargo run --manifest-path ...) from what I recall. Wiring to bootstrap seems fine though (probably good). @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 20, 2024
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#121560 (Allow `#[deny]` inside `#[forbid]` as a no-op) - rust-lang#131365 (Fix missing rustfmt in msi installer rust-lang#101993) - rust-lang#131647 (Register `src/tools/unicode-table-generator` as a runnable tool) - rust-lang#131843 (compiler: Error on layout of enums with invalid reprs) - rust-lang#131926 (Align boolean option descriptions in `configure.py`) - rust-lang#131961 (compiletest: tidy up how `tidy` and `tidy` (html version) are disambiguated) - rust-lang#131962 (Make `llvm::set_section` take a `&CStr`) - rust-lang#131964 (add latest crash tests) - rust-lang#131965 (remove outdated comment) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 20, 2024
Rollup merge of rust-lang#131647 - jieyouxu:unicode-table-generator, r=Mark-Simulacrum Register `src/tools/unicode-table-generator` as a runnable tool It seems like `src/tools/unicode-table-generator` is not currently managed by bootstrap. This PR wires it up with bootstrap as a runnable tool. This tool seems to take two possible args: 1. (Mandatory) path to `library/core/src/unicode/unicode_data.rs`, and 2. (Optional) path to generate a test file. I only passed the mandatory path to `unicode_data.rs` in bootstrap and didn't do anything about (2). I'm not sure about how this tool is supposed to be run. `Cargo.lock` is modified because I renamed `unicode-table-generator`'s bin name to match the tool name, as bootstrap's tool running logic expects the bin name to be derived from the tool name. I also added a triagebot message to remind to not manually edit the library source file and edit the tool then regenerate instead, but this should probably be a tidy check (if that's desirable then that can be in a follow-up PR, though may be overkill). Helps with rust-lang#131640 but does not close it because still no docs. r? `@Mark-Simulacrum` (since I think you authored this tool?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like
src/tools/unicode-table-generatoris not currently managed by bootstrap. This PR wires it up with bootstrap as a runnable tool.This tool seems to take two possible args:
library/core/src/unicode/unicode_data.rs, andI only passed the mandatory path to
unicode_data.rsin bootstrap and didn't do anything about (2). I'm not sure about how this tool is supposed to be run.Cargo.lockis modified because I renamedunicode-table-generator's bin name to match the tool name, as bootstrap's tool running logic expects the bin name to be derived from the tool name.I also added a triagebot message to remind to not manually edit the library source file and edit the tool then regenerate instead, but this should probably be a tidy check (if that's desirable then that can be in a follow-up PR, though may be overkill).
Helps with #131640 but does not close it because still no docs.
r? @Mark-Simulacrum (since I think you authored this tool?)