verify-grammar #13168
Merged
verify-grammar #13168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When calling make verify-grammar rust.md cannot be found, because the path to rust.md is missing. The path is set to: $(D)/rust.md This can only be tested, when llnextgen is installed. Signed-off-by: Jan Kobler <eng1@koblersystems.de>
When calling make verify-grammar or when llnextgen is not installed: python2.7 src/etc/extract_grammar.py <src/doc/rust.md an error is reported by extract_grammar.py that the keyword "crate" is not defined. This patch adds the keyword "crate" to the grammar in rust.md. Signed-off-by: Jan Kobler <eng1@koblersystems.de>
When calling
make verify-grammar
a lot of errors are reported by llnextgen.
Only simple errors like:
missing semicolons,
missing single quotes,
usage of parentheses instead of squared brackets or
usage of single quote instead of double quote
are fixed by this patch.
This can only be tested, when llnextgen is installed.
Signed-off-by: Jan Kobler <eng1@koblersystems.de>
|
Thanks a lot for fixing these things. I think these commits could be squashed together. |
|
Exciting. I didn't realize |
|
I r+ed without the squash since that appears to be the only nit and this history isn't bad. |
bors
added a commit
that referenced
this pull request
Mar 29, 2014
This fixes some problems with
make verify-grammar
llnextgen still reports a lot of errors
FYI: My build directory /my-test/build is different from the source directory /my-test/rust.
cd /my-test/build
/my-test/rust/configure --prefix=/my-test/bin
make
make install
make verify-grammar
dingxiangfei2009
pushed a commit
to dingxiangfei2009/rust
that referenced
this pull request
Jul 28, 2024
…=Manishearth Make `std_instead_of_core` somewhat MSRV aware For rust-lang#13158, this catches some things e.g. `core::net` and the recently stable `core::error` but not things moved individually like `UnwindSafe`, as far as I can see the version for those isn't easily available Beta nominating since ideally we'd get this change in the same version as `core::error` becomes stable cc `@kpreid` changelog: none
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Aug 26, 2024
…=Manishearth Make `std_instead_of_core` somewhat MSRV aware For rust-lang#13158, this catches some things e.g. `core::net` and the recently stable `core::error` but not things moved individually like `UnwindSafe`, as far as I can see the version for those isn't easily available Beta nominating since ideally we'd get this change in the same version as `core::error` becomes stable cc `@kpreid` changelog: none
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Aug 26, 2024
…=Manishearth Make `std_instead_of_core` somewhat MSRV aware For rust-lang#13158, this catches some things e.g. `core::net` and the recently stable `core::error` but not things moved individually like `UnwindSafe`, as far as I can see the version for those isn't easily available Beta nominating since ideally we'd get this change in the same version as `core::error` becomes stable cc `@kpreid` changelog: none
MabezDev
pushed a commit
to esp-rs/rust
that referenced
this pull request
Sep 3, 2024
…=Manishearth Make `std_instead_of_core` somewhat MSRV aware For rust-lang#13158, this catches some things e.g. `core::net` and the recently stable `core::error` but not things moved individually like `UnwindSafe`, as far as I can see the version for those isn't easily available Beta nominating since ideally we'd get this change in the same version as `core::error` becomes stable cc `@kpreid` changelog: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some problems with
llnextgen still reports a lot of errors
FYI: My build directory /my-test/build is different from the source directory /my-test/rust.
cd /my-test/build
/my-test/rust/configure --prefix=/my-test/bin
make
make install
make verify-grammar