Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #131690

Merged
merged 20 commits into from
Oct 14, 2024
Merged

Rollup of 8 pull requests #131690

merged 20 commits into from
Oct 14, 2024

Commits on Oct 8, 2024

  1. Configuration menu
    Copy the full SHA
    5db54be View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    0c41c34 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    84dacc1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aec09a4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a3606d7 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Remove unadorned

    compiler-errors committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    c085071 View commit details
    Browse the repository at this point in the history
  2. Note what qualifier

    compiler-errors committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    d6391d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Configuration menu
    Copy the full SHA
    d858dfe View commit details
    Browse the repository at this point in the history
  2. Fix AArch64InlineAsmReg::emit

    taiki-e committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    67ebb6c View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. Special treatment empty tuple when suggest adding a string literal in…

    … format macro.
    
    For example:
    ```rust
    let s = "123";
    println!({}, "sss", s);
    ```
    Suggest:
    `println!("{:?} {} {}", {}, "sss", s);`
    
    fixes rust-lang#130170
    surechen committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ceced53 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    cec5986 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9f42f94 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#129424 - coolreader18:stabilize-pin_as_dere…

    …f_mut, r=dtolnay
    
    Stabilize `Pin::as_deref_mut()`
    
    Tracking issue: closes rust-lang#86918
    
    Stabilizing the following API:
    
    ```rust
    impl<Ptr: DerefMut> Pin<Ptr> {
        pub fn as_deref_mut(self: Pin<&mut Pin<Ptr>>) -> Pin<&mut Ptr::Target>;
    }
    ```
    
    I know that an FCP has not been started yet, but this isn't a very complex stabilization, and I'm hoping this can motivate an FCP to *get* started - this has been pending for a while and it's a very useful function when writing Future impls.
    
    r? ``@jonhoo``
    matthiaskrgr authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    7ed6d1c View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#131332 - taiki-e:arm64ec-clobber-abi, r=Ama…

    …nieu
    
    Fix clobber_abi and disallow SVE-related registers in Arm64EC inline assembly
    
    Currently `clobber_abi` in Arm64EC inline assembly is implemented using `InlineAsmClobberAbi::AArch64NoX18`, but broken since it attempts to clobber registers that cannot be used in Arm64EC: https://godbolt.org/z/r3PTrGz5r
    
    ```
    error: cannot use register `x13`: x13, x14, x23, x24, x28, v16-v31 cannot be used for Arm64EC
     --> <source>:6:14
      |
    6 |     asm!("", clobber_abi("C"), options(nostack, nomem, preserves_flags));
      |              ^^^^^^^^^^^^^^^^
    
    error: cannot use register `x14`: x13, x14, x23, x24, x28, v16-v31 cannot be used for Arm64EC
     --> <source>:6:14
      |
    6 |     asm!("", clobber_abi("C"), options(nostack, nomem, preserves_flags));
      |              ^^^^^^^^^^^^^^^^
    
    <omitted the same errors for v16-v31>
    ```
    
    Additionally, this disallows SVE-related registers per rust-lang#131332 (comment).
    
    cc ``@dpaoliello``
    
    r? ``@Amanieu``
    
    ``@rustbot`` label O-windows O-AArch64 +A-inline-assembly
    matthiaskrgr authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    43bf4f1 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#131384 - saethlin:precondition-tests, r=ibr…

    …aheemdev
    
    Update precondition tests (especially for zero-size access to null)
    
    I don't much like the current way I've updated the precondition check helpers, but I couldn't come up with anything better. Ideas welcome.
    
    I've organized `tests/ui/precondition-checks` mostly with one file per function that has `assert_unsafe_precondition` in it, with revisions that check each precondition. The important new test is `tests/ui/precondition-checks/zero-size-null.rs`.
    matthiaskrgr authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    32062b4 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#131430 - surechen:fix_130495, r=jieyouxu

    Special treatment empty tuple when suggest adding a string literal in format macro.
    
    For example:
    ```rust
    let s = "123";
    println!({}, "sss", s);
    ```
    Suggest:
    `println!("{:?} {} {}", {}, "sss", s);`
    
    fixes rust-lang#130170
    matthiaskrgr authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    75231f8 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#131550 - compiler-errors:extern-diags, r=sp…

    …astorino
    
    Make some tweaks to extern block diagnostics
    
    Self-explanatory. See the diagnostic changes; I hope they make them a bit more descriptive.
    
    r? spastorino
    matthiaskrgr authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    b8cdca8 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#131667 - taiki-e:aarch64-inline-asm-reg-emi…

    …t, r=Amanieu
    
    Fix AArch64InlineAsmReg::emit
    
    Currently, this method uses `self as u32 - Self::x0 as u32` to get register index:
    https://github.com/rust-lang/rust/blob/36780360b62320a61e2234b17ec600e8e4785509/compiler/rustc_target/src/asm/aarch64.rs#L204
    
    However, this is incorrect for reasons explained in the following comment:
    https://github.com/rust-lang/rust/blob/36780360b62320a61e2234b17ec600e8e4785509/compiler/rustc_codegen_llvm/src/asm.rs#L544-L549
    
    r? ``@Amanieu``
    
    ``@rustbot`` label O-AArch64 +A-inline-assembly
    matthiaskrgr authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    dbb0581 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#131679 - Zalathar:ct-docs, r=jieyouxu

    compiletest: Document various parts of compiletest's `lib.rs`
    
    This adds some much-needed comments to many of the items in compiletest's `lib.rs`, giving a better overview of how a compiletest invocation actually proceeds.
    
    To make review easier I have refrained from renames or functional changes, though I couldn't resist getting rid of one obviously-redundant `Arc::clone` in `make_test_closure`.
    matthiaskrgr authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    53cfc10 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#131682 - jieyouxu:compiletest-label, r=Zala…

    …thar
    
    Tag PRs affecting compiletest with `A-compiletest`
    matthiaskrgr authored Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ac9b212 View commit details
    Browse the repository at this point in the history