Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 7 pull requests #131747

Merged
merged 17 commits into from
Oct 15, 2024
Merged

Rollup of 7 pull requests #131747

merged 17 commits into from
Oct 15, 2024

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    159e67d View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    0a9c87b View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2024

  1. Configuration menu
    Copy the full SHA
    9e0a7b9 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2024

  1. uefi: Implement getcwd and chdir

    - Using EFI Shell Protocol. These functions do not make much sense
      unless a shell is present.
    - Return the exe dir in case shell protocol is missing.
    
    Signed-off-by: Ayush Singh <ayush@beagleboard.org>
    Ayush1325 committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f8ac1c4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5a8405a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b73e613 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Make some float methods unstable const fn

    Some float methods are now `const fn` under the `const_float_methods` feature gate.
    
    In order to support `min`, `max`, `abs` and `copysign`, the implementation of some intrinsics had to be moved from Miri to rustc_const_eval.
    eduardosm committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    c09ed3e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d3d5905 View commit details
    Browse the repository at this point in the history
  3. Update arm64e-apple-tvos maintainer

    Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
    emmanuel-ferdman committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4e29e45 View commit details
    Browse the repository at this point in the history
  4. Fix most ui tests on emscripten target

    To fix the linker errors, we need to set the output extension to `.js` instead
    of `.wasm`. Setting the output to a `.wasm` file puts Emscripten into standalone
    mode which is effectively a distinct target. We need to set the runner to be
    `node` as well.
    
    This fixes most of the ui tests. I fixed a few more tests with simple problems:
    - `intrinsics/intrinsic-alignment.rs` and `structs-enums/rec-align-u64.rs` --
    Two `#[cfg]` macros match for Emscripten so we got a duplicate definition of
    `mod m`.
    - `issues/issue-12699.rs` -- Seems to hang so I disabled it
    - `process/process-sigpipe.rs` -- Not expected to work on Emscripten so I
    disabled it
    hoodmane committed Oct 15, 2024
    3 Configuration menu
    Copy the full SHA
    1d6643c View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#129794 - Ayush1325:uefi-os-expand, r=joboet

    uefi: Implement getcwd and chdir
    
    - Using EFI Shell Protocol. These functions do not make much sense unless a shell is present.
    - Return the exe dir in case shell protocol is missing.
    
    r? `@joboet`
    compiler-errors authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    34636e6 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#130568 - eduardosm:const-float-methods, r=R…

    …alfJung,tgross35
    
    Make some float methods unstable `const fn`
    
    Some float methods are now `const fn` under the `const_float_methods` feature gate.
    
    I also made some unstable methods `const fn`, keeping their constness under their respective feature gate.
    
    In order to support `min`, `max`, `abs` and `copysign`, the implementation of some intrinsics had to be moved from Miri to rustc_const_eval (cc `@RalfJung).`
    
    Tracking issue: rust-lang#130843
    
    ```rust
    impl <float> {
        // #[feature(const_float_methods)]
        pub const fn recip(self) -> Self;
        pub const fn to_degrees(self) -> Self;
        pub const fn to_radians(self) -> Self;
        pub const fn max(self, other: Self) -> Self;
        pub const fn min(self, other: Self) -> Self;
        pub const fn clamp(self, min: Self, max: Self) -> Self;
        pub const fn abs(self) -> Self;
        pub const fn signum(self) -> Self;
        pub const fn copysign(self, sign: Self) -> Self;
    
        // #[feature(float_minimum_maximum)]
        pub const fn maximum(self, other: Self) -> Self;
        pub const fn minimum(self, other: Self) -> Self;
    
        // Only f16/f128 (f32/f64 already const)
        pub const fn is_sign_positive(self) -> bool;
        pub const fn is_sign_negative(self) -> bool;
        pub const fn next_up(self) -> Self;
        pub const fn next_down(self) -> Self;
    }
    ```
    
    r? libs-api
    
    try-job: dist-s390x-linux
    compiler-errors authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2f3f001 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#131521 - jdonszelmann:rc, r=joboet

    rename RcBox to RcInner for consistency
    
    Arc uses ArcInner too (created in collaboration with `@aDotInTheVoid` and `@WaffleLapkin` )
    compiler-errors authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    1c799ff View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#131701 - compiler-errors:negative-bounds-on…

    …-unimplemented, r=lcnr
    
    Don't report `on_unimplemented` message for negative traits
    
    Kinda useless change but it was affecting my ability to read error messages when experimenting with negative bounds.
    compiler-errors authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    6558e34 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#131705 - hoodmane:fix-emscripten-tests, r=j…

    …ieyouxu
    
    Fix most ui tests on emscripten target
    
    To fix the linker errors, we need to set the output extension to `.js` instead of `.wasm`. Setting the output to a `.wasm` file puts Emscripten into standalone mode which is effectively a distinct target. We need to set the runner to be `node` as well.
    
    This fixes most of the ui tests. I fixed 4 additional tests with simple problems:
    
    - `intrinsics/intrinsic-alignment.rs` -- Two `#[cfg]` macros match for Emscripten so we got duplicate definition
    - `structs-enums/rec-align-u64.rs` -- same problem
    - `issues/issue-12699.rs` -- hangs so I disabled it
    - `process/process-sigpipe.rs` -- Not expected to work on Emscripten so I disabled it
    
    Resolves rust-lang#131666.
    
    There are 7 more failing tests. I'll try to investigate more and see if I can fix them or at least understand why they happen.
    
    - abi/numbers-arithmetic/return-float.rs (problem with [wasm treatment of noncanonical floats](https://webassembly.github.io/spec/core/exec/numerics.html#nan-propagation)?)
    - async-await/issue-60709.rs -- linker error related to memcpy. Possible Emscripten bug?
    - backtrace/dylib-dep.rs -- Says "Not supported"
    - backtrace/line-tables-only.rs -- Says "Not supported"
    - no_std/no-std-unwind-binary.rs -- compiler says `error: lang item required, but not found: eh_catch_typeinfo`
    - structs-enums/enum-rec/issue-17431-6.rs -- One of the two compiler errors is missing
    - test-attrs/test-passed.rs
    
        r?workingjubilee r?jieyouxu
    compiler-errors authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    fc1ad2e View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#131733 - practicalrs:fix_uninlined_format_a…

    …rgs, r=jieyouxu
    
    Fix uninlined_format_args in stable_mir
    
    Hi,
    
    This PR fixes some clippy warnings
    
    ```
    warning: variables can be used directly in the `format!` string
       --> compiler/stable_mir/src/mir/pretty.rs:362:13
        |
    362 |             write!(writer, "{kind}{:?}", place)
        |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#uninlined_format_args
        = note: requested on the command line with `-W clippy::uninlined-format-args`
    help: change this to
        |
    362 -             write!(writer, "{kind}{:?}", place)
    362 +             write!(writer, "{kind}{place:?}")
        |
    ```
    
    Best regards,
    Michal
    compiler-errors authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    53d1a66 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#131734 - emmanuel-ferdman:master, r=jieyouxu

    Update `arm64e-apple-tvos` maintainer
    
    # PR Summary
    Small PR - Updates the correct `arm64e-apple-tvos` maintainer.
    compiler-errors authored Oct 15, 2024
    Configuration menu
    Copy the full SHA
    d344fdf View commit details
    Browse the repository at this point in the history