Private struct fields by default #13184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Regarding your "Changes yet to be done", the RFC as written does not make any changes to enums. Removing |
|
Ah, sorry about that, I meant to send a separate RFC for that, and I forgot I didn't! |
This commit switches privacy's checking of fields to have *all* fields be private by default. This does not yet change tuple structs, this only affects structs with named fields. The fallout of this change will follow shortly. RFC: 0004-private-fields cc rust-lang#8122 Closes rust-lang#11809
bors
added a commit
that referenced
this pull request
Mar 31, 2014
This is an implementation of a portion of [RFC #4](https://github.com/rust-lang/rfcs/blob/master/active/0004-private-fields.md). This PR makes named struct fields private by default (as opposed to inherited by default). The only real meaty change is the first commit to `rustc`, all other commits are just fallout of that change. Summary of changes made: * Named fields are private by default *everywhere* * The `priv` keyword is now default-deny on named fields (done in a "lint" pass in privacy) Changes yet to be done (before the RFC is closed) * Change tuple structs to have private fields by default * Remove `priv` enum variants * Make `priv` a reserved keyword
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 1, 2014
This is a continuation of the work done in rust-lang#13184 to make struct fields private by default. This commit finishes RFC 4 by making all tuple structs have private fields by default. Note that enum variants are not affected. A tuple struct having a private field means that it cannot be matched on in a pattern match (both refutable and irrefutable), and it also cannot have a value specified to be constructed. Similarly to private fields, switching the type of a private field in a tuple struct should be able to be done in a backwards compatible way. The one snag that I ran into which wasn't mentioned in the RFC is that this commit also forbids taking the value of a tuple struct constructor. For example, this code now fails to compile: mod a { pub struct A(int); } let a: fn(int) -> a::A = a::A; //~ ERROR: first field is private Although no fields are bound in this example, it exposes implementation details through the type itself. For this reason, taking the value of a struct constructor with private fields is forbidden (outside the containing module). RFC: 0004-private-fields
|
If I am not mistaken, you missed the time module. Currently I cannot get the sec field from a Timespec struct. |
|
Ah great, thanks! |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 4, 2014
The calculation for whether a field is public or private was tweaked in rust-lang#13184, but I forgot to update rustdoc. Closes rust-lang#13310
This was referenced Apr 4, 2014
notriddle
pushed a commit
to notriddle/rust
that referenced
this pull request
Sep 20, 2022
Filter imports on find-all-references Attempt to rust-lang#13184
Jarcho
pushed a commit
to Jarcho/rust
that referenced
this pull request
Aug 24, 2024
fix false positive in explicit_iter_loop with msrv close rust-lang#13184 This PR fix false positive in explicit_iter_loop when msrv < 1.80 changelog: fix false positive in explicit_iter_loop when msrv < 1.80
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of a portion of RFC #4. This PR makes named struct fields private by default (as opposed to inherited by default).
The only real meaty change is the first commit to
rustc, all other commits are just fallout of that change.Summary of changes made:
privkeyword is now default-deny on named fields (done in a "lint" pass in privacy)Changes yet to be done (before the RFC is closed)
privenum variantspriva reserved keyword