Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update books #132007

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Update books #132007

merged 4 commits into from
Oct 25, 2024

Conversation

rustbot
Copy link
Collaborator

@rustbot rustbot commented Oct 21, 2024

rust-lang/edition-guide

7 commits in c7ebae25cb4801a31b6f05353f6d85bfa6feedd1..1f07c242f8162a711a5ac5a4ea8fa7ec884ee7a9
2024-10-21 14:29:49 UTC to 2024-10-19 19:08:20 UTC

rust-embedded/book

1 commits in f40a8b420ec4b4505d9489965e261f1d5c28ba23..ddbf1b4e2858fedb71b7c42eb15c4576517dc125
2024-10-13 19:53:37 UTC to 2024-10-13 19:53:37 UTC

rust-lang/reference

29 commits in c64e52a3d306eac0129f3ad6c6d8806ab99ae2e9..23ce619966541bf2c80d45fdfeecf3393e360a13
2024-10-05 00:33:03 +0000 to 2024-10-22 21:34:51 +0000

rust-lang/rustc-dev-guide

5 commits in 07bc9ca..59d94ea
2024-10-21 02:30:07 UTC to 2024-10-07 21:12:09 UTC

@rustbot
Copy link
Collaborator Author

rustbot commented Oct 21, 2024

r? @ehuss

rustbot has assigned @ehuss.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator Author

rustbot commented Oct 21, 2024

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 21, 2024
@rust-log-analyzer

This comment has been minimized.

@rust-log-analyzer

This comment has been minimized.

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Oct 23, 2024
@rust-log-analyzer

This comment has been minimized.

@ehuss
Copy link
Contributor

ehuss commented Oct 23, 2024

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Oct 23, 2024

📌 Commit df8551b has been approved by ehuss

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2024
@bors
Copy link
Contributor

bors commented Oct 24, 2024

⌛ Testing commit df8551b with merge 3dc1b9f...

@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #132007!

Tested on commit 3dc1b9f.
Direct link to PR: #132007

🎉 reference on linux: test-fail → test-pass (cc @Havvy @matthewjasper @ehuss).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Oct 25, 2024
Tested on commit rust-lang/rust@3dc1b9f.
Direct link to PR: <rust-lang/rust#132007>

🎉 reference on linux: test-fail → test-pass (cc @Havvy @matthewjasper @ehuss).
@bors
Copy link
Contributor

bors commented Oct 25, 2024

☀️ Test successful - checks-actions
Approved by: ehuss
Pushing 3dc1b9f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Oct 25, 2024
@bors bors merged commit 3dc1b9f into rust-lang:master Oct 25, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 25, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3dc1b9f): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
0.4% [0.4%, 0.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.4% [0.4%, 0.4%] 1

Max RSS (memory usage)

Results (secondary 2.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.2% [2.0%, 2.4%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 783.896s -> 784.265s (0.05%)
Artifact size: 333.71 MiB -> 333.71 MiB (0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants