-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Enable full debuginfo-level=2
in DEPLOY_ALT
#132010
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
ci: Enable full `debuginfo-level=2` in `DEPLOY_ALT` It will be slower to build and produce larger artifacts, but hopefully it will help catch debuginfo regressions sooner, especially for problems that LLVM assertions would uncover. try-job: dist-x86_64-linux try-job: dist-x86_64-linux-alt
This comment has been minimized.
This comment has been minimized.
💔 Test failed - checks-actions |
@rustbot blocked |
dd47d77
to
61cd0c7
Compare
Added #131944 (comment) @bors try |
ci: Enable full `debuginfo-level=2` in `DEPLOY_ALT` It will be slower to build and produce larger artifacts, but hopefully it will help catch debuginfo regressions sooner, especially for problems that LLVM assertions would uncover. try-job: dist-x86_64-linux try-job: dist-x86_64-linux-alt
☀️ Try build successful - checks-actions |
Hi @cuviper, it looks like the alt builds succeeded this time. Should we try to land this? |
I would be ok with landing this, especially if you want to give that added fix a review. @rustbot ready It would be nice to have a more targeted test too, like #131944 (comment) -- but I don't know if we can use real crate dependencies in our testsuite. |
You can in |
I would also want to be sure that external crate still pulls from vendored sources in offline builds -- but anyway #132613 should be a more proper fix, and then I'll drop the patch here and rebase the CI change alone. |
It will be slower to build and produce larger artifacts, but hopefully it will help catch debuginfo regressions sooner, especially for problems that LLVM assertions would uncover.
61cd0c7
to
fc83c8a
Compare
@bors try |
ci: Enable full `debuginfo-level=2` in `DEPLOY_ALT` It will be slower to build and produce larger artifacts, but hopefully it will help catch debuginfo regressions sooner, especially for problems that LLVM assertions would uncover. try-job: dist-x86_64-linux try-job: dist-x86_64-linux-alt
☀️ Try build successful - checks-actions |
@Mark-Simulacrum -- this is ready for review as a pure CI change now.
Somehow it was actually faster than its parent build, but that's probably noise. The size is quite significant though, using
|
If we don't want to affect |
@bors r+ I'm fine increasing the size of alt builds, that seems unlikely to break anyone. We can revert if we hit problems. |
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#132010 (ci: Enable full `debuginfo-level=2` in `DEPLOY_ALT`) - rust-lang#132310 (compiletest: add `max-llvm-major-version` directive) - rust-lang#132773 (PassWrapper: disable UseOdrIndicator for Asan Win32) - rust-lang#133013 (compiletest: known-bug / crashes: allow for an "auxiliary" directory to contain files that do not have a "known-bug" directive) - rust-lang#133027 (Fix a copy-paste issue in the NuttX raw type definition) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#132010 - cuviper:alt-full-debuginfo, r=Mark-Simulacrum ci: Enable full `debuginfo-level=2` in `DEPLOY_ALT` It will be slower to build and produce larger artifacts, but hopefully it will help catch debuginfo regressions sooner, especially for problems that LLVM assertions would uncover. try-job: dist-x86_64-linux try-job: dist-x86_64-linux-alt
It will be slower to build and produce larger artifacts, but hopefully
it will help catch debuginfo regressions sooner, especially for problems
that LLVM assertions would uncover.
try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt