Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable full debuginfo-level=2 in DEPLOY_ALT #132010

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Oct 21, 2024

It will be slower to build and produce larger artifacts, but hopefully
it will help catch debuginfo regressions sooner, especially for problems
that LLVM assertions would uncover.

try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt

@rustbot
Copy link
Collaborator

rustbot commented Oct 21, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 21, 2024
@cuviper
Copy link
Member Author

cuviper commented Oct 21, 2024

I expect the alt build to fail on #131944.

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 21, 2024
ci: Enable full `debuginfo-level=2` in `DEPLOY_ALT`

It will be slower to build and produce larger artifacts, but hopefully
it will help catch debuginfo regressions sooner, especially for problems
that LLVM assertions would uncover.

try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
Copy link
Contributor

bors commented Oct 21, 2024

⌛ Trying commit dd47d77 with merge 3e142fb...

@rust-log-analyzer

This comment has been minimized.

@bors
Copy link
Contributor

bors commented Oct 21, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 21, 2024
@cuviper
Copy link
Member Author

cuviper commented Oct 21, 2024

rustc: /checkout/src/llvm-project/llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:303: void llvm::Loc::MMI::addFrameIndexExpr(const DIExpression *, int): Assertion `(FrameIndexExprs.size() == 1 || llvm::all_of(FrameIndexExprs, [](const FrameIndexExpr &FIE) { return FIE.Expr && FIE.Expr->isFragment(); })) && "conflicting locations for variable"' failed.
[RUSTC-TIMING] cargo test:false 246.899
rustc exited with signal: 6 (SIGABRT) (core dumped)

@rustbot blocked

@rustbot rustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 21, 2024
@cuviper cuviper force-pushed the alt-full-debuginfo branch from dd47d77 to 61cd0c7 Compare October 22, 2024 18:15
@cuviper
Copy link
Member Author

cuviper commented Oct 22, 2024

Added #131944 (comment)

@bors try

@bors
Copy link
Contributor

bors commented Oct 22, 2024

⌛ Trying commit 61cd0c7 with merge 28380af...

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 22, 2024
ci: Enable full `debuginfo-level=2` in `DEPLOY_ALT`

It will be slower to build and produce larger artifacts, but hopefully
it will help catch debuginfo regressions sooner, especially for problems
that LLVM assertions would uncover.

try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
Copy link
Contributor

bors commented Oct 22, 2024

☀️ Try build successful - checks-actions
Build commit: 28380af (28380af8632392dcbf5153473388955f46275aee)

@wesleywiser
Copy link
Member

Hi @cuviper, it looks like the alt builds succeeded this time. Should we try to land this?

@cuviper
Copy link
Member Author

cuviper commented Oct 31, 2024

I would be ok with landing this, especially if you want to give that added fix a review.

@rustbot ready

It would be nice to have a more targeted test too, like #131944 (comment) -- but I don't know if we can use real crate dependencies in our testsuite.

@cuviper cuviper marked this pull request as ready for review October 31, 2024 22:38
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Oct 31, 2024
@jieyouxu
Copy link
Member

jieyouxu commented Nov 7, 2024

It would be nice to have a more targeted test too, like #131944 (comment) -- but I don't know if we can use real crate dependencies in our testsuite.

You can in run-make tests to invoke cargo to build an external crate... as long as that doesn't take an unreasonable amount of time.

@cuviper
Copy link
Member Author

cuviper commented Nov 7, 2024

I would also want to be sure that external crate still pulls from vendored sources in offline builds -- but anyway #132613 should be a more proper fix, and then I'll drop the patch here and rebase the CI change alone.

@jieyouxu
Copy link
Member

jieyouxu commented Nov 7, 2024

I would also want to be sure that external crate still pulls from vendored sources in offline builds -- but anyway #132613 should be a more proper fix, and then I'll drop the patch here and rebase the CI change alone.

Yeah, this is indeed a problem cf. #128733

It will be slower to build and produce larger artifacts, but hopefully
it will help catch debuginfo regressions sooner, especially for problems
that LLVM assertions would uncover.
@cuviper
Copy link
Member Author

cuviper commented Nov 11, 2024

@bors try

@bors
Copy link
Contributor

bors commented Nov 11, 2024

⌛ Trying commit fc83c8a with merge 8c5da65...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 11, 2024
ci: Enable full `debuginfo-level=2` in `DEPLOY_ALT`

It will be slower to build and produce larger artifacts, but hopefully
it will help catch debuginfo regressions sooner, especially for problems
that LLVM assertions would uncover.

try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@bors
Copy link
Contributor

bors commented Nov 11, 2024

☀️ Try build successful - checks-actions
Build commit: 8c5da65 (8c5da6539d0ddeedb04c64efc8d7636fb3641280)

@cuviper
Copy link
Member Author

cuviper commented Nov 11, 2024

@Mark-Simulacrum -- this is ready for review as a pure CI change now.

It will be slower to build and produce larger artifacts,

Somehow it was actually faster than its parent build, but that's probably noise. The size is quite significant though, using rustup-toolchain-install-master --alt.

@cuviper
Copy link
Member Author

cuviper commented Nov 13, 2024

If we don't want to affect DEPLOY_ALT, we could instead try increasing debug in some other llvm-asserting CI job.

@Mark-Simulacrum
Copy link
Member

@bors r+

I'm fine increasing the size of alt builds, that seems unlikely to break anyone. We can revert if we hit problems.

@bors
Copy link
Contributor

bors commented Nov 14, 2024

📌 Commit fc83c8a has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#132010 (ci: Enable full `debuginfo-level=2` in `DEPLOY_ALT`)
 - rust-lang#132310 (compiletest: add `max-llvm-major-version` directive)
 - rust-lang#132773 (PassWrapper: disable UseOdrIndicator for Asan Win32)
 - rust-lang#133013 (compiletest: known-bug / crashes: allow for an "auxiliary" directory to contain files that do not have a "known-bug" directive)
 - rust-lang#133027 (Fix a copy-paste issue in the NuttX raw type definition)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bce5fa6 into rust-lang:master Nov 14, 2024
7 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 14, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
Rollup merge of rust-lang#132010 - cuviper:alt-full-debuginfo, r=Mark-Simulacrum

ci: Enable full `debuginfo-level=2` in `DEPLOY_ALT`

It will be slower to build and produce larger artifacts, but hopefully
it will help catch debuginfo regressions sooner, especially for problems
that LLVM assertions would uncover.

try-job: dist-x86_64-linux
try-job: dist-x86_64-linux-alt
@cuviper cuviper deleted the alt-full-debuginfo branch November 27, 2024 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants