manual fixes + editor syntax highlighting #13207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nikomatsakis @pcwalton @brson In particular I'm not sure about the style here. I've taken some liberties in what I think the language reference should look like. I think that, after I'm done implementing tbaa, I will spend some significant time wrangling with the manual. |
|
(starting with a grammar) |
|
#13215 also adds support in vim for the new attribute syntax. |
| within. Attributes that are not terminated by a semi-colon apply to the next entity. | ||
| Attributes with a bang ("!") after the hash ("#") apply to the item that the | ||
| attribute is declared within. Attributes that do not have a bang after the | ||
| hash by a semi-colon apply to the next item. |
There was a problem hiding this comment.
there is no semi-colon in the new attributes syntax. why you mention it here?
There was a problem hiding this comment.
oops, bad edit, good catch.
Mostly around attributes and language items.
| attr : ident [ '=' literal | ||
| | '(' attr_list ')' ] ? ; | ||
| | '(' attr_list ')' ] ? |
There was a problem hiding this comment.
I'm pretty sure the terminating ; on the EBNF rules is required.
|
r=me with my comments addressed. |
|
@cmr r=me after squash. |
- Sort attributes lexicographically - Use new attribute syntax consistently - Fix wording describing new attribute syntax - Expand section on `repr`
bors
added a commit
that referenced
this pull request
Apr 4, 2014
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Sep 13, 2022
fix: add semicolon completion to mod fixes rust-lang#13196 `@Veykril` The tests are passing. I added one specifically for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.