Tweak E0277 output when a candidate is available #132147

estebank · 2024-10-25T18:04:21Z

Follow up to #132086.

Go from

error[E0277]: the trait bound `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>: CSTParser<'a>` is not satisfied
 --> src/main.rs:7:50
  |
7 | fn leaf<'a, O>(parser: impl CSTParser<'a, O>) -> impl CSTParser<'a, ()> {
  |                                                  ^^^^^^^^^^^^^^^^^^^^^^ the trait `chumsky::private::ParserSealed<'_, &str, (), chumsky::extra::Full<EmptyErr, (), ()>>` is not implemented for `Then<Ignored<Filter<Any<&str, ...>, ...>, ...>, ..., ..., ..., ...>`, which is required by `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>: CSTParser<'a>`
  |
  = help: the trait `chumsky::private::ParserSealed<'_, &'a str, ((), ()), chumsky::extra::Full<EmptyErr, (), ()>>` is implemented for `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>`
  = help: for that trait implementation, expected `((), ())`, found `()`
  = note: required for `Then<Ignored<Filter<Any<&str, ...>, ...>, ...>, ..., ..., ..., ...>` to implement `Parser<'_, &str, ()>`
note: required for `Then<Ignored<Filter<Any<&str, ...>, ...>, ...>, ..., ..., ..., ...>` to implement `CSTParser<'a>`
 --> src/main.rs:5:16
  |
5 | impl<'a, O, T> CSTParser<'a, O> for T where T: Parser<'a, &'a str, O> {}
  |                ^^^^^^^^^^^^^^^^     ^          ---------------------- unsatisfied trait bound introduced here
  = note: the full name for the type has been written to '/home/gh-estebank/longlong/target/debug/deps/longlong-0008f9a4f2023b08.long-type-13239977239800463552.txt'
  = note: consider using `--verbose` to print the full type name to the console
  = note: the full name for the type has been written to '/home/gh-estebank/longlong/target/debug/deps/longlong-0008f9a4f2023b08.long-type-13239977239800463552.txt'
  = note: consider using `--verbose` to print the full type name to the console

to

error[E0277]: the trait bound `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>: CSTParser<'a>` is not satisfied
  --> src/main.rs:7:50
   |
7  | fn leaf<'a, O>(parser: impl CSTParser<'a, O>) -> impl CSTParser<'a, ()> {
   |                                                  ^^^^^^^^^^^^^^^^^^^^^^ unsatisfied trait bound
...
11 |     ws.then(parser.map(|_| ()))
   |     --------------------------- return type was inferred to be `Then<Ignored<..., ...>, ..., ..., ..., ...>` here
   |
   = help: the trait `ParserSealed<'_, &_, (), Full<_, _, _>>` is not implemented for `Then<Ignored<..., ...>, ..., ..., ..., ...>`
           but trait `ParserSealed<'_, &'a _, ((), ()), Full<_, _, _>>` is implemented for it
   = help: for that trait implementation, expected `((), ())`, found `()`
   = note: required for `Then<Ignored<..., ...>, ..., ..., ..., ...>` to implement `Parser<'_, &str, ()>`
note: required for `Then<Ignored<..., ...>, ..., ..., ..., ...>` to implement `CSTParser<'a>`
  --> src/main.rs:5:16
   |
5  | impl<'a, O, T> CSTParser<'a, O> for T where T: Parser<'a, &'a str, O> {}
   |                ^^^^^^^^^^^^^^^^     ^          ---------------------- unsatisfied trait bound introduced here
   = note: the full name for the type has been written to '/home/gh-estebank/longlong/target/debug/deps/longlong-df9d52be87eada65.long-type-1337037744507305372.txt'
   = note: consider using `--verbose` to print the full type name to the console

Remove redundant wording
Introduce trait diff highlighting logic and use it
Fix incorrect "long type written to path" logic (can be split off)
Point at tail expression in more cases in E0277
Avoid long primary span labels in E0277 by moving them to a help

Fix #132013.

There are individual commits that can be their own PR. If the review load is too big, happy to split them off.

rustbot · 2024-10-25T18:04:31Z

r? @Nadrieril

rustbot has assigned @Nadrieril.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

estebank · 2024-10-25T18:10:46Z

tests/ui/impl-trait/diagnostics/highlight-difference-between-expected-trait-and-found-trait.svg

This is the main test we want to look at, but some of the changes (like tweaking the printing of diffed types and of the long type file) aren't present here.

The output for the repro:

After all of the other changes, I am tempted at removing the "for that trait implementation, expected..." help, as it makes it more explicit, but is already implicitly present in the line above.

compiler-errors · 2024-10-25T19:56:01Z

I think splitting out the fourth commit, which touches almost every E0277, is probably the best action. Right now, it makes it practically impossible to critique any other change in this PR, because right now those practically just drown in the diff. This is especially true because the rest of the changes stacked on top have very little to do with each other, and imo could land in parallel after that large change lands.

estebank · 2024-10-25T22:16:20Z

Split-off 4th commit to #132157.

tests/ui/traits/negative-bounds/simple.stderr

Nadrieril · 2024-10-27T19:34:22Z

r? compiler

bors · 2024-10-29T23:10:17Z

☔ The latest upstream changes (presumably #132326) made this pull request unmergeable. Please resolve the merge conflicts.

davidtwco · 2024-10-31T13:33:15Z

r=me after rebasing

estebank · 2024-11-01T19:36:29Z

@bors r=davidtwco

bors · 2024-11-01T19:36:32Z

📌 Commit 083d70f has been approved by davidtwco

It is now in the queue for this repository.

Tweak E0277 output when a candidate is available *Follow up to rust-lang#132086.* Go from ``` error[E0277]: the trait bound `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>: CSTParser<'a>` is not satisfied --> src/main.rs:7:50 | 7 | fn leaf<'a, O>(parser: impl CSTParser<'a, O>) -> impl CSTParser<'a, ()> { | ^^^^^^^^^^^^^^^^^^^^^^ the trait `chumsky::private::ParserSealed<'_, &str, (), chumsky::extra::Full<EmptyErr, (), ()>>` is not implemented for `Then<Ignored<Filter<Any<&str, ...>, ...>, ...>, ..., ..., ..., ...>`, which is required by `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>: CSTParser<'a>` | = help: the trait `chumsky::private::ParserSealed<'_, &'a str, ((), ()), chumsky::extra::Full<EmptyErr, (), ()>>` is implemented for `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>` = help: for that trait implementation, expected `((), ())`, found `()` = note: required for `Then<Ignored<Filter<Any<&str, ...>, ...>, ...>, ..., ..., ..., ...>` to implement `Parser<'_, &str, ()>` note: required for `Then<Ignored<Filter<Any<&str, ...>, ...>, ...>, ..., ..., ..., ...>` to implement `CSTParser<'a>` --> src/main.rs:5:16 | 5 | impl<'a, O, T> CSTParser<'a, O> for T where T: Parser<'a, &'a str, O> {} | ^^^^^^^^^^^^^^^^ ^ ---------------------- unsatisfied trait bound introduced here = note: the full name for the type has been written to '/home/gh-estebank/longlong/target/debug/deps/longlong-0008f9a4f2023b08.long-type-13239977239800463552.txt' = note: consider using `--verbose` to print the full type name to the console = note: the full name for the type has been written to '/home/gh-estebank/longlong/target/debug/deps/longlong-0008f9a4f2023b08.long-type-13239977239800463552.txt' = note: consider using `--verbose` to print the full type name to the console ``` to ``` error[E0277]: the trait bound `Then<Ignored<chumsky::combinator::Filter<chumsky::primitive::Any<&str, chumsky::extra::Full<EmptyErr, (), ()>>, {closure@src/main.rs:9:17: 9:27}>, char>, chumsky::combinator::Map<impl CSTParser<'a, O>, O, {closure@src/main.rs:11:24: 11:27}>, (), (), chumsky::extra::Full<EmptyErr, (), ()>>: CSTParser<'a>` is not satisfied --> src/main.rs:7:50 | 7 | fn leaf<'a, O>(parser: impl CSTParser<'a, O>) -> impl CSTParser<'a, ()> { | ^^^^^^^^^^^^^^^^^^^^^^ unsatisfied trait bound ... 11 | ws.then(parser.map(|_| ())) | --------------------------- return type was inferred to be `Then<Ignored<..., ...>, ..., ..., ..., ...>` here | = help: the trait `ParserSealed<'_, &_, (), Full<_, _, _>>` is not implemented for `Then<Ignored<..., ...>, ..., ..., ..., ...>` but trait `ParserSealed<'_, &'a _, ((), ()), Full<_, _, _>>` is implemented for it = help: for that trait implementation, expected `((), ())`, found `()` = note: required for `Then<Ignored<..., ...>, ..., ..., ..., ...>` to implement `Parser<'_, &str, ()>` note: required for `Then<Ignored<..., ...>, ..., ..., ..., ...>` to implement `CSTParser<'a>` --> src/main.rs:5:16 | 5 | impl<'a, O, T> CSTParser<'a, O> for T where T: Parser<'a, &'a str, O> {} | ^^^^^^^^^^^^^^^^ ^ ---------------------- unsatisfied trait bound introduced here = note: the full name for the type has been written to '/home/gh-estebank/longlong/target/debug/deps/longlong-df9d52be87eada65.long-type-1337037744507305372.txt' = note: consider using `--verbose` to print the full type name to the console ``` * Remove redundant wording * Introduce trait diff highlighting logic and use it * Fix incorrect "long type written to path" logic (can be split off) * Point at tail expression in more cases in E0277 * Avoid long primary span labels in E0277 by moving them to a `help` Fix rust-lang#132013. There are individual commits that can be their own PR. If the review load is too big, happy to split them off.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#131037 (Move versioned Apple LLVM targets from `rustc_target` to `rustc_codegen_ssa`) - rust-lang#132147 (Tweak E0277 output when a candidate is available) - rust-lang#132398 (Add a couple of intra-doc links to str) - rust-lang#132453 (Also treat `impl` definition parent as transparent regarding modules) - rust-lang#132457 (Remove needless #![feature(asm_experimental_arch)] from loongarch64 inline assembly test) - rust-lang#132465 (refactor(config): remove FIXME statement in comment of `omit-git-hash`) - rust-lang#132471 (Add a bunch of mailmap entries) r? `@ghost` `@rustbot` modify labels: rollup

matthiaskrgr · 2024-11-02T02:56:03Z

@bors r-
needs rebase I think

When a trait is not implemented for a type, but there *is* an `impl` for another type or different trait params, we format the output to use highlighting in the same way that E0308 does for types. The logic accounts for 3 cases: - When both the type and trait in the expected predicate and the candidate are different - When only the types are different - When only the trait generic params are different For each case, we use slightly different formatting and wording.

Remove default note for "trait is not implemented" in favor of the more colorful diff output from the previous commit. Removes duplicated output.

Make sure that we append to the file for long ty paths. Do not write the same type more than once. Shorten the calculated width a bit.

``` error[E0277]: the trait bound `{gen block@$DIR/gen_block_is_coro.rs:7:5: 7:8}: Coroutine` is not satisfied --> $DIR/gen_block_is_coro.rs:6:13 | LL | fn foo() -> impl Coroutine<Yield = u32, Return = ()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `Coroutine` is not implemented for `{gen block@$DIR/gen_block_is_coro.rs:7:5: 7:8}` LL | gen { yield 42 } | ---------------- return type was inferred to be `{gen block@$DIR/gen_block_is_coro.rs:7:5: 7:8}` here ``` The secondary span label is new.

Long span labels don't read well.

Do not suggest `#[derive(Copy)]` when we wanted a `!Copy` type. Do not say "`Copy` is not implemented for `T` but `Copy` is". Do not talk about `Trait` having no implementations when `!Trait` was desired.

Paths in CI can be longer than in devs' machines.

estebank · 2024-11-02T17:00:32Z

@matthiaskrgr it ended up being that the type name length of types that include paths (closures and coroutines) is longer in CI than in devs' machines because in CI they show the full path, and then change that customized output to avoid longer span labels triggered in CI and not in my environment :-/

@bors r=davidtwco

bors · 2024-11-02T17:00:35Z

📌 Commit 7e0d3ed has been approved by davidtwco

It is now in the queue for this repository.

bors · 2024-11-02T20:22:52Z

⌛ Testing commit 7e0d3ed with merge b3f75cc...

bors · 2024-11-02T22:55:03Z

☀️ Test successful - checks-actions
Approved by: davidtwco
Pushing b3f75cc to master...

rust-timer · 2024-11-03T00:12:10Z

Finished benchmarking commit (b3f75cc): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.4%	[1.4%, 1.4%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.1%	[-2.1%, -2.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 4.1%, secondary 4.5%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.1%	[4.1%, 4.1%]	1
Regressions ❌ (secondary)	4.5%	[4.5%, 4.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	4.1%	[4.1%, 4.1%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 780.047s -> 781.635s (0.20%)
Artifact size: 335.36 MiB -> 335.39 MiB (0.01%)

rustbot assigned Nadrieril Oct 25, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Oct 25, 2024

estebank force-pushed the long-types-2 branch from d6485d0 to 3a764ba Compare October 25, 2024 18:07

estebank commented Oct 25, 2024

View reviewed changes

estebank mentioned this pull request Oct 25, 2024

Tweak E0277 highlighting and "long type" path printing #132086

Merged

This comment was marked as resolved.

Sign in to view

estebank force-pushed the long-types-2 branch from 3a764ba to 5c98c87 Compare October 25, 2024 19:41

estebank force-pushed the long-types-2 branch from 5c98c87 to 6ed0e24 Compare October 25, 2024 22:15

estebank force-pushed the long-types-2 branch from 6ed0e24 to b074eb1 Compare October 25, 2024 22:19

estebank commented Oct 25, 2024

View reviewed changes

tests/ui/traits/negative-bounds/simple.stderr Outdated Show resolved Hide resolved

rustbot assigned davidtwco and unassigned Nadrieril Oct 27, 2024

estebank force-pushed the long-types-2 branch from 382372f to 8763b04 Compare October 29, 2024 15:58

davidtwco approved these changes Oct 31, 2024

View reviewed changes

estebank force-pushed the long-types-2 branch from 8763b04 to 083d70f Compare November 1, 2024 17:32

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 1, 2024

matthiaskrgr mentioned this pull request Nov 1, 2024

Rollup of 7 pull requests #132476

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 2, 2024

estebank added 8 commits November 2, 2024 03:08

Trim output of E0277 in some cases

7b9105d

Remove default note for "trait is not implemented" in favor of the more colorful diff output from the previous commit. Removes duplicated output.

Fix type shortening writing to file

c6017ba

Make sure that we append to the file for long ty paths. Do not write the same type more than once. Shorten the calculated width a bit.

Use short_ty_string

86b5965

On long E0277 primary span label, move it to a help

1a0c502

Long span labels don't read well.

Account for negative bounds in E0277 note and suggestion

143b072

Do not suggest `#[derive(Copy)]` when we wanted a `!Copy` type. Do not say "`Copy` is not implemented for `T` but `Copy` is". Do not talk about `Trait` having no implementations when `!Trait` was desired.

fix tests

7e0d3ed

Paths in CI can be longer than in devs' machines.

estebank force-pushed the long-types-2 branch from 083d70f to 7e0d3ed Compare November 2, 2024 16:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 2, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 2, 2024

bors merged commit b3f75cc into rust-lang:master Nov 2, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Nov 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tweak E0277 output when a candidate is available #132147

Tweak E0277 output when a candidate is available #132147

estebank commented Oct 25, 2024 •

edited

Loading

rustbot commented Oct 25, 2024

estebank Oct 25, 2024

estebank Oct 25, 2024

This comment was marked as resolved.

compiler-errors commented Oct 25, 2024 •

edited

Loading

estebank commented Oct 25, 2024

Nadrieril commented Oct 27, 2024

bors commented Oct 29, 2024

davidtwco commented Oct 31, 2024

estebank commented Nov 1, 2024

bors commented Nov 1, 2024

matthiaskrgr commented Nov 2, 2024

estebank commented Nov 2, 2024

bors commented Nov 2, 2024

bors commented Nov 2, 2024

bors commented Nov 2, 2024

rust-timer commented Nov 3, 2024

Tweak E0277 output when a candidate is available #132147

Tweak E0277 output when a candidate is available #132147

Conversation

estebank commented Oct 25, 2024 • edited Loading

rustbot commented Oct 25, 2024

estebank Oct 25, 2024

Choose a reason for hiding this comment

estebank Oct 25, 2024

Choose a reason for hiding this comment

This comment was marked as resolved.

compiler-errors commented Oct 25, 2024 • edited Loading

estebank commented Oct 25, 2024

Nadrieril commented Oct 27, 2024

bors commented Oct 29, 2024

davidtwco commented Oct 31, 2024

estebank commented Nov 1, 2024

bors commented Nov 1, 2024

matthiaskrgr commented Nov 2, 2024

estebank commented Nov 2, 2024

bors commented Nov 2, 2024

bors commented Nov 2, 2024

bors commented Nov 2, 2024

rust-timer commented Nov 3, 2024

Overall result: ❌✅ regressions and improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

estebank commented Oct 25, 2024 •

edited

Loading

compiler-errors commented Oct 25, 2024 •

edited

Loading