Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rustdoc] Unify variant struct fields margins with struct fields #132258

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

GuillaumeGomez
Copy link
Member

As discussed in #132220.

before after
image Screenshot from 2024-10-28 11-17-24

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 28, 2024
@rustbot
Copy link
Collaborator

rustbot commented Oct 28, 2024

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha

@notriddle
Copy link
Contributor

Sure.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 28, 2024

📌 Commit 26b6ccd has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2024
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 28, 2024
…s-margins, r=notriddle

[rustdoc] Unify variant struct fields margins with struct fields

As discussed in rust-lang#132220.

| before | after |
|-|-|
| ![image](https://github.com/user-attachments/assets/d8d8336d-7fe4-45fb-a5a5-36a4023223f5) | ![Screenshot from 2024-10-28 11-17-24](https://github.com/user-attachments/assets/9d0d9633-b857-45b4-9217-7d0d1aa8f770) |

r? `@notriddle`
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Oct 28, 2024
…s-margins, r=notriddle

[rustdoc] Unify variant struct fields margins with struct fields

As discussed in rust-lang#132220.

| before | after |
|-|-|
| ![image](https://github.com/user-attachments/assets/d8d8336d-7fe4-45fb-a5a5-36a4023223f5) | ![Screenshot from 2024-10-28 11-17-24](https://github.com/user-attachments/assets/9d0d9633-b857-45b4-9217-7d0d1aa8f770) |

r? ``@notriddle``
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 28, 2024
…kingjubilee

Rollup of 9 pull requests

Successful merges:

 - rust-lang#130259 (Lower AST node id only once)
 - rust-lang#131441 (Add a new trait `proc_macro::ToTokens`)
 - rust-lang#132247 (stable_mir: Directly use types from rustc_abi)
 - rust-lang#132249 (compiler: Add rustc_abi dependence to the compiler)
 - rust-lang#132255 (Add `LayoutS::is_uninhabited` and use it)
 - rust-lang#132258 ([rustdoc] Unify variant struct fields margins with struct fields)
 - rust-lang#132260 (cg_llvm: Use a type-safe helper to cast `&str` and `&[u8]` to `*const c_char`)
 - rust-lang#132261 (refactor: cleaner check to return None)
 - rust-lang#132271 (Updating Fuchsia platform-support documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 29, 2024
…s-margins, r=notriddle

[rustdoc] Unify variant struct fields margins with struct fields

As discussed in rust-lang#132220.

| before | after |
|-|-|
| ![image](https://github.com/user-attachments/assets/d8d8336d-7fe4-45fb-a5a5-36a4023223f5) | ![Screenshot from 2024-10-28 11-17-24](https://github.com/user-attachments/assets/9d0d9633-b857-45b4-9217-7d0d1aa8f770) |

r? ````@notriddle````
workingjubilee added a commit to workingjubilee/rustc that referenced this pull request Oct 29, 2024
…s-margins, r=notriddle

[rustdoc] Unify variant struct fields margins with struct fields

As discussed in rust-lang#132220.

| before | after |
|-|-|
| ![image](https://github.com/user-attachments/assets/d8d8336d-7fe4-45fb-a5a5-36a4023223f5) | ![Screenshot from 2024-10-28 11-17-24](https://github.com/user-attachments/assets/9d0d9633-b857-45b4-9217-7d0d1aa8f770) |

r? `````@notriddle`````
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 29, 2024
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#130259 (Lower AST node id only once)
 - rust-lang#131441 (Add a new trait `proc_macro::ToTokens`)
 - rust-lang#132247 (stable_mir: Directly use types from rustc_abi)
 - rust-lang#132249 (compiler: Add rustc_abi dependence to the compiler)
 - rust-lang#132255 (Add `LayoutData::is_uninhabited` and use it)
 - rust-lang#132258 ([rustdoc] Unify variant struct fields margins with struct fields)
 - rust-lang#132260 (cg_llvm: Use a type-safe helper to cast `&str` and `&[u8]` to `*const c_char`)
 - rust-lang#132261 (refactor: cleaner check to return None)
 - rust-lang#132271 (Updating Fuchsia platform-support documentation)
 - rust-lang#132295 (fixed wast version was released, remove randomization exemption)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 29, 2024
…kingjubilee

Rollup of 9 pull requests

Successful merges:

 - rust-lang#130259 (Lower AST node id only once)
 - rust-lang#131441 (Add a new trait `proc_macro::ToTokens`)
 - rust-lang#132247 (stable_mir: Directly use types from rustc_abi)
 - rust-lang#132249 (compiler: Add rustc_abi dependence to the compiler)
 - rust-lang#132255 (Add `LayoutData::is_uninhabited` and use it)
 - rust-lang#132258 ([rustdoc] Unify variant struct fields margins with struct fields)
 - rust-lang#132260 (cg_llvm: Use a type-safe helper to cast `&str` and `&[u8]` to `*const c_char`)
 - rust-lang#132261 (refactor: cleaner check to return None)
 - rust-lang#132271 (Updating Fuchsia platform-support documentation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 6ea83ff into rust-lang:master Oct 29, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Oct 29, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Oct 29, 2024
Rollup merge of rust-lang#132258 - GuillaumeGomez:variant-structfields-margins, r=notriddle

[rustdoc] Unify variant struct fields margins with struct fields

As discussed in rust-lang#132220.

| before | after |
|-|-|
| ![image](https://github.com/user-attachments/assets/d8d8336d-7fe4-45fb-a5a5-36a4023223f5) | ![Screenshot from 2024-10-28 11-17-24](https://github.com/user-attachments/assets/9d0d9633-b857-45b4-9217-7d0d1aa8f770) |

r? ```@notriddle```
@GuillaumeGomez GuillaumeGomez deleted the variant-structfields-margins branch October 29, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants