Reject raw lifetime followed by `'`, like regular lifetimes do #132341

compiler-errors · 2024-10-30T01:13:25Z

See comment. We want to reject cases like 'r#long'id, which currently gets interpreted as a raw lifetime ('r#long) followed by a lifetime ('id). This could have alternative lexes, such as an overlong char literal ('r#long') followed by an identifier (id). To avoid committing to this in any case, let's reject the whole thing.

@mattheww, is this what you were looking for in rust-lang/reference#1603 (comment)? I'd say ignore the details about the specific error message (the fact that this gets reinterpreted as a char literal is 🤷), just that because this causes a lexer error we're effectively saving syntactical space like you wanted.

rustbot · 2024-10-30T01:13:35Z

r? @chenyukang

rustbot has assigned @chenyukang.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

compiler-errors · 2024-10-30T01:14:59Z

Nominating as an easy decision because this is really new syntax and it saves space.

If we want to go through with this, I'd say we also beta nominate it because raw lifetimes are landing next edition, though I guess we could land them out of sync because I doubt anyone will begin relying on this obscure behavior of a somewhat obscure feature in 6 weeks.

mattheww · 2024-10-30T14:59:35Z

Yes, that's what I was thinking of.

I think #132341 (comment) has a typo, and should be saying

We want to reject cases like 'r#long'id

joshtriplett · 2024-10-30T15:39:24Z

@rfcbot merge

rfcbot · 2024-10-30T15:39:27Z

Team member @joshtriplett has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

cc @rust-lang/lang-advisors: FCP proposed for lang, please feel free to register concerns.
See this document for info about what commands tagged team members can give me.

tmandry · 2024-10-30T15:39:55Z

@rfcbot reviewed

nikomatsakis · 2024-10-30T15:39:57Z

@rfcbot reviewed

traviscross · 2024-10-30T15:39:57Z

@rfcbot reveiwed

rfcbot · 2024-10-30T15:40:20Z

🔔 This is now entering its final comment period, as per the review above. 🔔

traviscross · 2024-10-30T19:03:35Z

@rustbot labels -I-lang-nominated

We discussed this in triage today, and as above, this seemed a clear call to us.

apiraino · 2024-10-31T14:11:12Z

Beta backport accepted as per compiler team on Zulip, after it gets merged. A backport PR will be authored by the release team at the end of the current development cycle.

@rustbot label +beta-accepted

rfcbot · 2024-11-09T15:55:56Z

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

This will be merged soon.

compiler-errors · 2024-11-09T16:43:07Z

@bors r=chenyukang

bors · 2024-11-09T16:43:10Z

📌 Commit 1990f15 has been approved by chenyukang

It is now in the queue for this repository.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#132341 (Reject raw lifetime followed by `'`, like regular lifetimes do) - rust-lang#132363 (Enforce that raw lifetimes must be valid raw identifiers) - rust-lang#132744 (add regression test for rust-lang#90781) - rust-lang#132754 (Simplify the internal API for declaring command-line options) - rust-lang#132772 (use `download-rustc="if-unchanged"` as a global default) - rust-lang#132774 (Use lld with non-LLVM backends) - rust-lang#132799 (Make `Ty::primitive_symbol` recognize `str`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#132341 - compiler-errors:raw-lt-prefix-id, r=chenyukang Reject raw lifetime followed by `'`, like regular lifetimes do See comment. We want to reject cases like `'r#long'id`, which currently gets interpreted as a raw lifetime (`'r#long`) followed by a lifetime (`'id`). This could have alternative lexes, such as an overlong char literal (`'r#long'`) followed by an identifier (`id`). To avoid committing to this in any case, let's reject the whole thing. `@mattheww,` is this what you were looking for in rust-lang/reference#1603 (comment)? I'd say ignore the details about the specific error message (the fact that this gets reinterpreted as a char literal is 🤷), just that because this causes a lexer error we're effectively saving syntactical space like you wanted.

…r=chenyukang Reject raw lifetime followed by `'`, like regular lifetimes do See comment. We want to reject cases like `'r#long'id`, which currently gets interpreted as a raw lifetime (`'r#long`) followed by a lifetime (`'id`). This could have alternative lexes, such as an overlong char literal (`'r#long'`) followed by an identifier (`id`). To avoid committing to this in any case, let's reject the whole thing. `@mattheww,` is this what you were looking for in rust-lang/reference#1603 (comment)? I'd say ignore the details about the specific error message (the fact that this gets reinterpreted as a char literal is 🤷), just that because this causes a lexer error we're effectively saving syntactical space like you wanted.

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#132341 (Reject raw lifetime followed by `'`, like regular lifetimes do) - rust-lang#132363 (Enforce that raw lifetimes must be valid raw identifiers) - rust-lang#132744 (add regression test for rust-lang#90781) - rust-lang#132754 (Simplify the internal API for declaring command-line options) - rust-lang#132772 (use `download-rustc="if-unchanged"` as a global default) - rust-lang#132774 (Use lld with non-LLVM backends) - rust-lang#132799 (Make `Ty::primitive_symbol` recognize `str`) r? `@ghost` `@rustbot` modify labels: rollup

[beta] backports - Use completion item indices instead of property matching rust-lang#132987, rust-lang/rust-analyzer#18503 - Reject raw lifetime followed by `'`, like regular lifetimes do rust-lang#132341 - Only disable cache if predicate has opaques within it rust-lang#132625 - rustdoc-search: case-sensitive only when capitals are used rust-lang#133043 r? cuviper

[beta] backports - Use completion item indices instead of property matching rust-lang#132987, rust-lang/rust-analyzer#18503 - Reject raw lifetime followed by `'`, like regular lifetimes do rust-lang#132341 - Only disable cache if predicate has opaques within it rust-lang#132625 - rustdoc-search: case-sensitive only when capitals are used rust-lang#133043 - (ci) Update macOS Xcode to 15 rust-lang#131570 r? cuviper

mattheww · 2024-11-25T23:49:53Z

I think this caused #133479

…ebank Only error raw lifetime followed by `\'` in edition 2021+ Fixes rust-lang#133479 cc rust-lang#132341 I think this fixes a purely theoretical regression since it only affects edition 2015 (who is using that?) and only in the very rare case of a raw lifetime followed immediately by a lifetime like `'r#a'r`.

This mirrors the changes from rust-lang/rust#132341 which have been backported to appear in Rust 1.83

Rollup merge of rust-lang#133482 - compiler-errors:raw-lt-tick, r=estebank Only error raw lifetime followed by `\'` in edition 2021+ Fixes rust-lang#133479 cc rust-lang#132341 I think this fixes a purely theoretical regression since it only affects edition 2015 (who is using that?) and only in the very rare case of a raw lifetime followed immediately by a lifetime like `'r#a'r`.

Reject raw lifetime followed by \' as well

1990f15

compiler-errors marked this pull request as ready for review October 30, 2024 01:13

rustbot assigned chenyukang Oct 30, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2024

compiler-errors added I-lang-nominated Nominated for discussion during a lang team meeting. I-lang-easy-decision Issue: The decision needed by the team is conjectured to be easy; this does not imply nomination labels Oct 30, 2024

compiler-errors added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 30, 2024

compiler-errors changed the title ~~Reject raw lifetime followed by ' like lifetimes~~ Reject raw lifetime followed by ', like regular lifetimes do Oct 30, 2024

compiler-errors mentioned this pull request Oct 30, 2024

Enforce that raw lifetimes must be valid raw identifiers #132363

Merged

joshtriplett added T-lang Relevant to the language team, which will review and decide on the PR/issue. and removed T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 30, 2024

rfcbot added proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. disposition-merge This issue / PR is in PFCP or FCP with a disposition to merge it. labels Oct 30, 2024

joshtriplett added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 30, 2024

rfcbot added final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. and removed proposed-final-comment-period Proposed to merge/close by relevant subteam, see T-<team> label. Will enter FCP once signed off. labels Oct 30, 2024

rustbot removed the I-lang-nominated Nominated for discussion during a lang team meeting. label Oct 30, 2024

rustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 31, 2024

compiler-errors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Nov 1, 2024

rfcbot added finished-final-comment-period The final comment period is finished for this PR / Issue. to-announce Announce this issue on triage meeting and removed final-comment-period In the final comment period and will be merged soon unless new substantive objections are raised. labels Nov 9, 2024

rustbot mentioned this pull request Nov 9, 2024

Tracking issue for release notes of #132341: Reject raw lifetime followed by ', like regular lifetimes do #132810

Closed

3 tasks

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 9, 2024

matthiaskrgr mentioned this pull request Nov 9, 2024

Rollup of 7 pull requests #132815

Merged

bors merged commit 9b50092 into rust-lang:master Nov 9, 2024
6 checks passed

rustbot added this to the 1.84.0 milestone Nov 9, 2024

cuviper mentioned this pull request Nov 15, 2024

[beta] backports #133077

Merged

cuviper modified the milestones: 1.84.0, 1.83.0 Nov 15, 2024

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Nov 15, 2024

compiler-errors deleted the raw-lt-prefix-id branch November 20, 2024 04:27

mattheww mentioned this pull request Nov 25, 2024

rustc 1.83 lexing regression in the 2015 edition: 'r#x'y #133479

Closed

compiler-errors mentioned this pull request Nov 26, 2024

Only error raw lifetime followed by \' in edition 2021+ #133482

Merged

mattheww added a commit to mattheww/lexeywan that referenced this pull request Dec 1, 2024

Make ' a forbidden follower for the RawLifetimeOrLabel rule

93b3775

This mirrors the changes from rust-lang/rust#132341 which have been backported to appear in Rust 1.83

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Reject raw lifetime followed by `'`, like regular lifetimes do #132341

Reject raw lifetime followed by `'`, like regular lifetimes do #132341

compiler-errors commented Oct 30, 2024 •

edited

Loading

rustbot commented Oct 30, 2024

compiler-errors commented Oct 30, 2024

mattheww commented Oct 30, 2024 •

edited

Loading

joshtriplett commented Oct 30, 2024

rfcbot commented Oct 30, 2024 •

edited by traviscross

Loading

tmandry commented Oct 30, 2024

nikomatsakis commented Oct 30, 2024

traviscross commented Oct 30, 2024

rfcbot commented Oct 30, 2024

traviscross commented Oct 30, 2024 •

edited

Loading

apiraino commented Oct 31, 2024

rfcbot commented Nov 9, 2024

compiler-errors commented Nov 9, 2024

bors commented Nov 9, 2024

mattheww commented Nov 25, 2024

Reject raw lifetime followed by ', like regular lifetimes do #132341

Reject raw lifetime followed by ', like regular lifetimes do #132341

Conversation

compiler-errors commented Oct 30, 2024 • edited Loading

rustbot commented Oct 30, 2024

compiler-errors commented Oct 30, 2024

mattheww commented Oct 30, 2024 • edited Loading

joshtriplett commented Oct 30, 2024

rfcbot commented Oct 30, 2024 • edited by traviscross Loading

tmandry commented Oct 30, 2024

nikomatsakis commented Oct 30, 2024

traviscross commented Oct 30, 2024

rfcbot commented Oct 30, 2024

traviscross commented Oct 30, 2024 • edited Loading

apiraino commented Oct 31, 2024

rfcbot commented Nov 9, 2024

compiler-errors commented Nov 9, 2024

bors commented Nov 9, 2024

mattheww commented Nov 25, 2024

Reject raw lifetime followed by `'`, like regular lifetimes do #132341

Reject raw lifetime followed by `'`, like regular lifetimes do #132341

compiler-errors commented Oct 30, 2024 •

edited

Loading

mattheww commented Oct 30, 2024 •

edited

Loading

rfcbot commented Oct 30, 2024 •

edited by traviscross

Loading

traviscross commented Oct 30, 2024 •

edited

Loading