Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make download-rustc="if-unchanged" default for library profile #132494

Merged
merged 2 commits into from
Nov 2, 2024

Conversation

onur-ozkan
Copy link
Member

Since download-rustc is tested on CI and #132267 makes it effective for library development, we can now make it default for the library profile.

Implements the 3rd item from this tracking issue.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2024

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 2, 2024
@rustbot
Copy link
Collaborator

rustbot commented Nov 2, 2024

This PR modifies src/bootstrap/defaults.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me if Ralf agrees with the [build] changes (which looks right to me FWIW)

@onur-ozkan
Copy link
Member Author

@bors r=jieyouxu

@bors
Copy link
Contributor

bors commented Nov 2, 2024

📌 Commit 329dacf has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 2, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2024
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#132481 (rustdoc: skip stability inheritance for some item kinds)
 - rust-lang#132482 (library: fix some stability annotations)
 - rust-lang#132493 (Fix type reference in documents which was being confused with html tags.)
 - rust-lang#132494 (make `download-rustc="if-unchanged"` default for library profile)
 - rust-lang#132495 (Remove unintended link)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit bfcd9ec into rust-lang:master Nov 2, 2024
8 of 12 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 2, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 2, 2024
Rollup merge of rust-lang#132494 - onur-ozkan:library-profile-default, r=jieyouxu

make `download-rustc="if-unchanged"` default for library profile

Since `download-rustc` is tested on CI and rust-lang#132267 makes it effective for library development, we can now make it default for the library profile.

Implements the 3rd item from [this tracking issue](rust-lang#131744).
@bors
Copy link
Contributor

bors commented Nov 2, 2024

⌛ Testing commit 329dacf with merge 07cbbdd...

@onur-ozkan onur-ozkan deleted the library-profile-default branch November 2, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants