Rollup of 6 pull requests #132581

workingjubilee · 2024-11-03T23:25:01Z

Successful merges:

Call the target libdir target libdir #126136 (Call the target libdir target libdir)
Add bad-reg inline assembly ui test for RISC-V and s390x #132516 (Add bad-reg inline assembly ui test for RISC-V and s390x)
replace manual time convertions with std ones, comptime time format parsing #132521 (replace manual time convertions with std ones, comptime time format parsing)
Remove outdated tidy license fixmes #132560 (Remove outdated tidy license fixmes)
Modify NonZero documentation to reference the underlying integer type #132563 (Modify NonZero documentation to reference the underlying integer type)
compiler: Directly use rustc_abi almost everywhere #132574 (compiler: Directly use rustc_abi almost everywhere)

r? @ghost
@rustbot modify labels: rollup

`f32`, `f64` and `asm!` macro.

Co-authored-by: Jubilee <workingjubilee@gmail.com>

This also adds comments explaining the difference to bad-reg.rs.

Because it's the target libdir. `--print` uses the same terminology, and it's a simple way to make it obviously different from `$sysroot/lib`.

This change updates the documentation for `NonZero` integer types to explicitly reference the underlying integer type each `NonZero` variant wraps, instead of using a general "integer" term.

Stop reexporting ReprOptions from middle::ty

…-ozkan Call the target libdir target libdir Because it's the target libdir. `--print` uses the same terminology, and it's a simple way to make it obviously different from `$sysroot/lib`.

Add bad-reg inline assembly ui test for RISC-V and s390x rust-lang#131341 (comment) > Btw, such unsupported registers are present in most architectures, but only aarch64/arm64ec, x86_64, and not yet merged [sparc/sparc64](https://github.com/rust-lang/rust/pull/132472/files#diff-02aebda3376c2b020265137f9ce2c387669ca5cfecd7d60494275c2387db5114) (and powerpc/powerpc64 by this PR) currently have ui tests for them. I plan to add tests for other arches later. Starting with RISC-V and s390x, which I'm familiar with and relatively easy to check for correctness. (Relevant rustc code are supported_types/def_regs/overlapping_regs in [compiler/rustc_target/src/asm/riscv.rs](https://github.com/rust-lang/rust/blob/588a4203508ed7c76750c96b482641261630ed36/compiler/rustc_target/src/asm/riscv.rs) and [compiler/rustc_target/src/asm/s390x.rs](https://github.com/rust-lang/rust/blob/588a4203508ed7c76750c96b482641261630ed36/compiler/rustc_target/src/asm/s390x.rs).) r? workingjubilee `@rustbot` label +A-inline-assembly

replace manual time convertions with std ones, comptime time format parsing First commit replaces few manual time conversions with std ones, second makes parsing of time format at compiletime.

Remove outdated tidy license fixmes ~~This PR re-enables license dependency checking for:~~ - ~~the `backtrace` submodule~~ - ~~and the `portable-simd` subtree~~ ~~The `stdarch` submodule doesn't have a `Cargo.lock` yet so we can't re-enable it.~~ This PR removes outdated tidy license fixmes, rust-lang#132560 (comment). r? bootstrap

Modify `NonZero` documentation to reference the underlying integer type This change updates the documentation for `NonZero` integer types to explicitly reference the underlying integer type each `NonZero` variant wraps, instead of using a general "integer" term. **Before** ![image](https://github.com/user-attachments/assets/b13bda82-007b-459c-8b22-e27d79005271) **After** ![image](https://github.com/user-attachments/assets/1d7fadc7-dce3-4b84-9b8f-d2bb81c05eb7)

…compiler-errors compiler: Directly use rustc_abi almost everywhere Use rustc_abi instead of rustc_target where applicable. This is mostly described by the following substitutions: ```rust match path_substring { rustc_target::spec::abi::Abi => rustc_abi::ExternAbi, rustc_target::abi::call => rustc_target::callconv, rustc_target::abi => rustc_abi, } ``` A number of spot-fixes make that not quite the whole story. The main exception is in 33edc68 where I get a lot more persnickety about how things are imported, especially in `rustc_middle::ty::layout`, not just from where. This includes putting an end to a reexport of `rustc_middle::ty::ReprOptions`, for the same reason that the rest of this change is happening: reexports mostly confound things. This notably omits rustc_passes and the ast crates, as I'm still examining a question I have about how they do stability checking of `extern "Abi"` strings and if I can simplify their logic. The rustc_abi and rustc_target crates also go untouched because they will be entangled in that cleanup. r? compiler-errors

workingjubilee · 2024-11-03T23:25:09Z

@bors r+ rollup=never p=6

bors · 2024-11-03T23:25:12Z

📌 Commit 72df778 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2024-11-04T00:54:22Z

⌛ Testing commit 72df778 with merge 43c7805...

bors · 2024-11-04T04:02:23Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 43c7805 to master...

rust-timer · 2024-11-04T04:04:05Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#126136	Call the target libdir target libdir	`f01977fbc2f131b26f0bf95e145ba00f1233a1aa` (link)
#132516	Add bad-reg inline assembly ui test for RISC-V and s390x	`3e5d2a7081191a9ec85610910965d4b124c66b31` (link)
#132521	replace manual time convertions with std ones, comptime tim…	`af2aa2205a1eb6582682d01de05ffaa3e414acf6` (link)
#132560	Remove outdated tidy license fixmes	`b2e59059b5492d34396a2a5bd823f981cd3292f5` (link)
#132563	Modify `NonZero` documentation to reference the underlying …	`326eccfa9361c2f8de3283b232c98ff1ae82d28a` (link)
#132574	compiler: Directly use rustc_abi almost everywhere	`e0d54ff4de8d991f2cb78f379c254ef0293c8ec1` (link)

previous master: 42188c3ca8

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-11-04T08:25:30Z

Finished benchmarking commit (43c7805): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.1%, secondary -4.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.1%	[-2.1%, -2.1%]	1
Improvements ✅ (secondary)	-4.7%	[-4.7%, -4.7%]	1
All ❌✅ (primary)	-2.1%	[-2.1%, -2.1%]	1

Cycles

Results (secondary 2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 779.973s -> 780.005s (0.00%)
Artifact size: 335.34 MiB -> 335.27 MiB (-0.02%)

taiki-e and others added 27 commits November 2, 2024 21:37

Add bad-reg inline assembly ui test for RISC-V and s390x

e97ba53

Add more core stubs to minicore

89a1077

`f32`, `f64` and `asm!` macro.

Adjust tests to use minicore and rebless

5596a59

Fix typo in tests/auxiliary/minicore.rs

a7520ad

Co-authored-by: Jubilee <workingjubilee@gmail.com>

Move tests/ui/abi/riscv32e-registers.rs to tests/ui/asm/riscv

b07232d

This also adds comments explaining the difference to bad-reg.rs.

Call the target libdir target libdir

f42fb43

Because it's the target libdir. `--print` uses the same terminology, and it's a simple way to make it obviously different from `$sysroot/lib`.

replace manual time convertions with std ones

be3a635

make time format parsing compiletime

bc1d8e7

Modify NonZero documentation to reference the underlying integer type

9d66cfa

This change updates the documentation for `NonZero` integer types to explicitly reference the underlying integer type each `NonZero` variant wraps, instead of using a general "integer" term.

Remove outdated tidy license fixmes

b3fc11b

compiler: Directly use rustc_abi in codegen

b895bf4

compiler: Directly use rustc_abi in const_eval

bbd18e2

compiler: Directly use rustc_abi in hir_{analysis,typeck}

89ec8c2

compiler: Directly use rustc_abi in metadata and middle

236fe33

Stop reexporting ReprOptions from middle::ty

compiler: Directly use rustc_abi in mir_transform

843b6e0

compiler: Directly use rustc_abi in smir again

6c16a31

compiler: Directly use rustc_abi in ty_utils

092135b

compiler: Directly use rustc_abi in lints

586e141

compiler: Directly use rustc_abi in session

7639773

compiler: Replace rustc_target with abi in symbol_mangling

5c953ee

compiler: Remove unused rustc_target from Cargo.tomls

fa20473

Rollup merge of rust-lang#126136 - Noratrieb:bootstrap-naming, r=onur…

deb4ceb

…-ozkan Call the target libdir target libdir Because it's the target libdir. `--print` uses the same terminology, and it's a simple way to make it obviously different from `$sysroot/lib`.

Rollup merge of rust-lang#132521 - klensy:times, r=compiler-errors

3285d12

replace manual time convertions with std ones, comptime time format parsing First commit replaces few manual time conversions with std ones, second makes parsing of time format at compiletime.

rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2024

rustbot added T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 3, 2024

rustbot added the rollup A PR which is a rollup label Nov 3, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 3, 2024

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 4, 2024

bors merged commit 43c7805 into rust-lang:master Nov 4, 2024
7 checks passed

rustbot added this to the 1.84.0 milestone Nov 4, 2024

workingjubilee deleted the rollup-4wj318p branch November 4, 2024 04:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 6 pull requests #132581

Rollup of 6 pull requests #132581

workingjubilee commented Nov 3, 2024

workingjubilee commented Nov 3, 2024

bors commented Nov 3, 2024

bors commented Nov 4, 2024

bors commented Nov 4, 2024

rust-timer commented Nov 4, 2024

rust-timer commented Nov 4, 2024

Rollup of 6 pull requests #132581

Rollup of 6 pull requests #132581

Conversation

workingjubilee commented Nov 3, 2024

workingjubilee commented Nov 3, 2024

bors commented Nov 3, 2024

bors commented Nov 4, 2024

bors commented Nov 4, 2024

rust-timer commented Nov 4, 2024

rust-timer commented Nov 4, 2024

Overall result: ❌ regressions - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size