Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add myself into users_on_vacation on triagebot #133036

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

onur-ozkan
Copy link
Member

I will be on vacation for about 10 days.

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot
Copy link
Collaborator

rustbot commented Nov 14, 2024

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2024
@@ -976,8 +976,8 @@ warn_non_default_branch = true
contributing_url = "https://rustc-dev-guide.rust-lang.org/getting-started.html"
users_on_vacation = [
"jieyouxu",
"jyn514",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They don't seem to appear anywhere in this file, so I removed them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jyn is on alumni status so yeah

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that jyn wanted to remain there to avoid rustbot pings, IIRC, as some people were still pinging jyn months after they stopped actively working on the Project.

(somewhat ironically) @jyn514 Do you still want to be in this list?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does rustbot ping people that aren't in the triagebot file? That sounds weird 🤔

Copy link
Member

@jieyouxu jieyouxu Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right good point, I think people can still r/? jyn otherwise?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

at the time i left you couldn’t assign PRs to people outside the org. if that’s still the case i'm happy for you to remove me from this list.

Signed-off-by: onur-ozkan <work@onurozkan.dev>
@jieyouxu
Copy link
Member

Enjor ur vacation!
@bors r+ rollup (you can self r+ such PRs)

@bors
Copy link
Contributor

bors commented Nov 14, 2024

📌 Commit 83e4d3b has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 14, 2024
@jieyouxu
Copy link
Member

@bors r- (maybe wait for jyn or drop jyn from this PR?)

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 14, 2024
@rust-lang rust-lang deleted a comment from rustbot Nov 14, 2024
@jieyouxu
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Nov 14, 2024

📌 Commit 2b8c345 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 14, 2024
@onur-ozkan
Copy link
Member Author

onur-ozkan commented Nov 14, 2024

@bors r=jieyouxu

Oops. Race condition xd

@bors
Copy link
Contributor

bors commented Nov 14, 2024

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Nov 14, 2024

📌 Commit 2b8c345 has been approved by jieyouxu

It is now in the queue for this repository.

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#132172 (borrowck diagnostics: suggest borrowing function inputs in generic positions)
 - rust-lang#132649 (add ./x clippy ci)
 - rust-lang#133005 (rustdoc: use a trie for name-based search)
 - rust-lang#133034 (update download-rustc comments and default)
 - rust-lang#133036 (add myself into `users_on_vacation` on triagebot)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 35214eb into rust-lang:master Nov 14, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 14, 2024
Rollup merge of rust-lang#133036 - onur-ozkan:vacation, r=jieyouxu

add myself into `users_on_vacation` on triagebot

I will be on vacation for about 10 days.
@rustbot rustbot added this to the 1.84.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants