-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add myself into users_on_vacation
on triagebot
#133036
Conversation
rustbot has assigned @Mark-Simulacrum. Use |
|
@@ -976,8 +976,8 @@ warn_non_default_branch = true | |||
contributing_url = "https://rustc-dev-guide.rust-lang.org/getting-started.html" | |||
users_on_vacation = [ | |||
"jieyouxu", | |||
"jyn514", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They don't seem to appear anywhere in this file, so I removed them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jyn is on alumni status so yeah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that jyn wanted to remain there to avoid rustbot pings, IIRC, as some people were still pinging jyn months after they stopped actively working on the Project.
(somewhat ironically) @jyn514 Do you still want to be in this list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does rustbot ping people that aren't in the triagebot file? That sounds weird 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right good point, I think people can still r/? jyn otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at the time i left you couldn’t assign PRs to people outside the org. if that’s still the case i'm happy for you to remove me from this list.
Signed-off-by: onur-ozkan <work@onurozkan.dev>
Enjor ur vacation! |
@bors r- (maybe wait for jyn or drop jyn from this PR?) |
@bors r+ rollup |
Oops. Race condition xd |
💡 This pull request was already approved, no need to approve it again.
|
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#132172 (borrowck diagnostics: suggest borrowing function inputs in generic positions) - rust-lang#132649 (add ./x clippy ci) - rust-lang#133005 (rustdoc: use a trie for name-based search) - rust-lang#133034 (update download-rustc comments and default) - rust-lang#133036 (add myself into `users_on_vacation` on triagebot) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#133036 - onur-ozkan:vacation, r=jieyouxu add myself into `users_on_vacation` on triagebot I will be on vacation for about 10 days.
I will be on vacation for about 10 days.