Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let chains tests #133093

Merged
merged 2 commits into from
Nov 17, 2024
Merged

Let chains tests #133093

merged 2 commits into from
Nov 17, 2024

Conversation

est31
Copy link
Member

@est31 est31 commented Nov 16, 2024

Filing this as this marks off two of the open issues in #132833:

  • extending the tests for move-guard-if-let-chain.rs and conflicting_bindings.rs to have chains with multiple let's (one implementation could for example search for the first let and then terminate).
  • An instance where a temporary lives shorter than with nested ifs, breaking compilation: Temporary does not live long enough in let chains #103476. This was fixed in the end by the if let rescoping work.

Closes #103476

@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2024

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 16, 2024
@traviscross traviscross assigned traviscross and unassigned pnkfelix Nov 16, 2024
@traviscross
Copy link
Contributor

@bors r+ rollup=always

@bors
Copy link
Contributor

bors commented Nov 16, 2024

📌 Commit f502dce has been approved by traviscross

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 16, 2024

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 16, 2024
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 17, 2024
Let chains tests

Filing this as this marks off two of the open issues in rust-lang#132833:

* extending the tests for `move-guard-if-let-chain.rs` and `conflicting_bindings.rs` to have chains with multiple let's (one implementation could for example search for the first `let` and then terminate).
* An instance where a temporary lives shorter than with nested ifs, breaking compilation: rust-lang#103476. This was fixed in the end by the if let rescoping work.

Closes rust-lang#103476
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2024
Rollup of 8 pull requests

Successful merges:

 - rust-lang#131717 (Stabilize `const_atomic_from_ptr`)
 - rust-lang#132449 (mark is_val_statically_known intrinsic as stably const-callable)
 - rust-lang#132569 (rustdoc search: allow queries to end in an empty path segment)
 - rust-lang#133029 (ABI checks: add support for some tier3 arches, warn on others.)
 - rust-lang#133093 (Let chains tests)
 - rust-lang#133097 (Opt out TaKO8Ki from review rotation for now)
 - rust-lang#133116 (stabilize const_ptr_is_null)
 - rust-lang#133126 (alloc: fix `String`'s doc)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2024
Rollup of 6 pull requests

Successful merges:

 - rust-lang#133029 (ABI checks: add support for some tier3 arches, warn on others.)
 - rust-lang#133051 (Increase accuracy of `if` condition misparse suggestion)
 - rust-lang#133060 (Trim whitespace in RemoveLet primary span)
 - rust-lang#133093 (Let chains tests)
 - rust-lang#133116 (stabilize const_ptr_is_null)
 - rust-lang#133126 (alloc: fix `String`'s doc)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ccc3f86 into rust-lang:master Nov 17, 2024
6 checks passed
@rustbot rustbot added this to the 1.84.0 milestone Nov 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 17, 2024
Rollup merge of rust-lang#133093 - est31:let_chains_tests, r=traviscross

Let chains tests

Filing this as this marks off two of the open issues in rust-lang#132833:

* extending the tests for `move-guard-if-let-chain.rs` and `conflicting_bindings.rs` to have chains with multiple let's (one implementation could for example search for the first `let` and then terminate).
* An instance where a temporary lives shorter than with nested ifs, breaking compilation: rust-lang#103476. This was fixed in the end by the if let rescoping work.

Closes rust-lang#103476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Temporary does not live long enough in let chains
5 participants