Make `compare_impl_item` into a query #133365

compiler-errors · 2024-11-23T04:52:12Z

Turns compare_impl_item into a query (generalizing the existing query for compare_impl_const), and uses that in Instance::resolve to fail resolution when an implementation is incompatible with the trait it comes from.

Fixes #119701
Fixes #121127
Fixes #121411
Fixes #129075
Fixes #129127
Fixes #129214
Fixes #131294

compiler-errors · 2024-11-23T04:52:28Z

@bors try @rust-timer queue

bors · 2024-11-23T04:53:38Z

⌛ Trying commit c7ca253 with merge 507b0fd...

…=<try> Make `compare_impl_item` into a query First want to perf, then I'll write something up. r? `@ghost`

bors · 2024-11-23T06:40:49Z

☀️ Try build successful - checks-actions
Build commit: 507b0fd (507b0fdc53b493f2fe2f88a18d7b1f00914beafe)

rust-timer · 2024-11-23T08:30:03Z

Finished benchmarking commit (507b0fd): comparison URL.

Overall result: ❌ regressions - please read the text below

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.4%]	37
Regressions ❌ (secondary)	0.4%	[0.2%, 0.5%]	10
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.4%]	37

Max RSS (memory usage)

Results (primary -0.9%, secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.0%	[2.0%, 2.0%]	1
Regressions ❌ (secondary)	2.2%	[2.2%, 2.2%]	1
Improvements ✅ (primary)	-1.9%	[-2.6%, -1.4%]	3
Improvements ✅ (secondary)	-1.7%	[-1.7%, -1.7%]	1
All ❌✅ (primary)	-0.9%	[-2.6%, 2.0%]	4

Cycles

Results (primary -2.2%, secondary 9.6%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	9.6%	[9.6%, 9.6%]	1
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.2%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.2%, -2.2%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 795.253s -> 795.718s (0.06%)
Artifact size: 336.22 MiB -> 335.54 MiB (-0.20%)

compiler-errors · 2024-11-23T15:40:09Z

@bors try @rust-timer queue

…=<try> Make `compare_impl_item` into a query First want to perf, then I'll write something up. r? `@ghost`

bors · 2024-11-23T15:41:19Z

⌛ Trying commit 1b30977 with merge d249c37...

bors · 2024-11-23T15:55:33Z

💔 Test failed - checks-actions

compiler-errors · 2024-11-23T16:05:39Z

@bors try @rust-timer queue

bors · 2024-11-23T16:06:48Z

⌛ Trying commit 4ece9e6 with merge 9dedd09...

…=<try> Make `compare_impl_item` into a query First want to perf, then I'll write something up. r? `@ghost`

bors · 2024-11-23T17:50:26Z

☀️ Try build successful - checks-actions
Build commit: 9dedd09 (9dedd0907e6ca8addde92511267c83ff2d1f6a22)

bors · 2024-11-26T09:25:39Z

💔 Test failed - checks-actions

lcnr · 2024-11-26T10:42:01Z

@bors retry

…=lcnr Make `compare_impl_item` into a query Turns `compare_impl_item` into a query (generalizing the existing query for `compare_impl_const`), and uses that in `Instance::resolve` to fail resolution when an implementation is incompatible with the trait it comes from. Fixes rust-lang#119701 Fixes rust-lang#121127 Fixes rust-lang#121411 Fixes rust-lang#129075 Fixes rust-lang#129127 Fixes rust-lang#129214 Fixes rust-lang#131294

bors · 2024-11-27T00:42:39Z

⌛ Testing commit a1d9da3 with merge 5857540...

bors · 2024-11-27T02:12:42Z

💔 Test failed - checks-actions

compiler-errors · 2024-11-27T02:29:51Z

lmao, ok I think I know how to turn this into a cycle 🤔

should be able to fix this by removing the refinement check from this logic

lcnr · 2024-11-27T08:06:39Z

gamer!

lcnr · 2024-11-30T20:23:48Z

@bors r+ rollup=never

bors · 2024-11-30T20:23:50Z

📌 Commit 1e655ef has been approved by lcnr

It is now in the queue for this repository.

bors · 2024-12-01T01:59:27Z

⌛ Testing commit 1e655ef with merge 4af7fa7...

bors · 2024-12-01T04:52:54Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 4af7fa7 to master...

rust-timer · 2024-12-01T06:10:57Z

Finished benchmarking commit (4af7fa7): comparison URL.

Overall result: ❌ regressions - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	0.3%	[0.2%, 0.5%]	27
Regressions ❌ (secondary)	0.4%	[0.3%, 1.3%]	7
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.3%	[0.2%, 0.5%]	27

Max RSS (memory usage)

Results (primary 0.1%, secondary 4.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[0.5%, 1.6%]	2
Regressions ❌ (secondary)	4.0%	[4.0%, 4.0%]	1
Improvements ✅ (primary)	-1.7%	[-1.7%, -1.7%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-1.7%, 1.6%]	3

Cycles

Results (primary -2.3%, secondary -2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-2.4%	[-2.7%, -2.1%]	13
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 774.339s -> 774.422s (0.01%)
Artifact size: 332.31 MiB -> 332.10 MiB (-0.06%)

rylev · 2024-12-04T03:11:32Z

Perf regressions were excused here

@rustbot label: +perf-regression-triaged

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 23, 2024