Constify Drop and Destruct
#133402
Merged
Constify Drop and Destruct
#133402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
commented
Nov 24, 2024
| @@ -25,6 +25,8 @@ const fn check<T: ~const Destruct>(_: T) {} | |||
| macro_rules! check_all { | |||
| ($($exp:expr),*$(,)?) => {$( | |||
| const _: () = check($exp); | |||
| //~^ ERROR the trait bound `NonTrivialDrop: const Destruct` is not satisfied | |||
There was a problem hiding this comment.
The span here sucks because we point at the span of the check($exp) expr, rather than pointing at the argument. I plan on fixing that soon.
lcnr
reviewed
Nov 25, 2024
lcnr
reviewed
Nov 25, 2024
lcnr
reviewed
Nov 25, 2024
compiler-errors
force-pushed
the
drop-and-destruct
branch
from
98926dc to
bd44b63
Compare
|
@bors r=lcnr |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 27, 2024
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#115293 (Remove -Zfuel.) - rust-lang#132605 (CI: increase timeout from 4h to 6h) - rust-lang#133304 (Revert diagnostics hack to fix ICE 132920) - rust-lang#133402 (Constify `Drop` and `Destruct`) - rust-lang#133458 (Fix `Result` and `Option` not getting a jump to def link generated) - rust-lang#133471 (gce: fix typing_mode mismatch) - rust-lang#133475 (`MaybeStorage` improvements) - rust-lang#133513 (Only ignore windows-gnu in avr-jmp-offset) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 27, 2024
Rollup merge of rust-lang#133402 - compiler-errors:drop-and-destruct, r=lcnr Constify `Drop` and `Destruct` r? `@lcnr` or `@fee1-dead`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @lcnr or @fee1-dead