Point out which struct's field is private #13346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben0x539
changed the title
... is private" error
| @@ -578,10 +578,42 @@ impl<'a> PrivacyVisitor<'a> { | |||
| }; | |||
| if field.vis == ast::Public { return } | |||
| if !is_local(field.id) || !self.private_accessible(field.id.node) { | |||
There was a problem hiding this comment.
Could you change this if statement to if foo { return }?
Just to help reduce the amount of indentation.
|
This looks great, nice work! Just a few small comments and I think this is good to go. |
|
Thank you for your comments! How is this? |
bors
added a commit
that referenced
this pull request
Apr 6, 2014
In the error message for when a private field is used, include the name of the struct, or if it's a struct-like enum variant, the names of the variant and the enum. This fixes #13341.
|
Awesome, thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the error message for when a private field is used, include the name of the struct, or if it's a struct-like enum variant, the names of the variant and the enum.
This fixes #13341.