Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

collections: replace all ~[T] with Vec<T>. #13350

Merged
merged 2 commits into from
Apr 10, 2014

Conversation

huonw
Copy link
Member

@huonw huonw commented Apr 6, 2014

collections: replace all ~[T] with Vec.

@alexcrichton
Copy link
Member

I have yet to be convinced that ~[T] is inappropriate for apis such as this, but I believe that the push and pop methods need to be removed ASAP, and this is progress towards removing those methods.

@huonw
Copy link
Member Author

huonw commented Apr 7, 2014

Updated with a minor adjustment to assert_eq! (using match to extend the lifetimes a little). r?

(It's the first commit topologically, but github's doing its chronological display thing, i.e. r+'s on the collections: ... commit please.)

bors added a commit that referenced this pull request Apr 7, 2014
collections: replace all ~[T] with Vec<T>.
huonw added 2 commits April 9, 2014 09:57
This enables

    assert_eq!(foo.collect::<Vec<...>>().as_slice(), &[1,2,3,4]);

to work, by extending the lifetime of the .as_slice() rvalue.
bors added a commit that referenced this pull request Apr 10, 2014
collections: replace all ~[T] with Vec<T>.
bors added a commit that referenced this pull request Apr 10, 2014
collections: replace all ~[T] with Vec<T>.
@bors bors closed this Apr 10, 2014
@bors bors merged commit 4b9a7a2 into rust-lang:master Apr 10, 2014
bors added a commit that referenced this pull request Apr 10, 2014
Closes #13441 (debuginfo: Fixes and improvements for #12840, #12886, and #13213)
Closes #13433 (Remove references to @trait from a compiler error message)
Closes #13430 (Fix outdated lint warning about inner attribute)
Closes #13425 (Remove a pile of (mainly) internal `~[]` uses)
Closes #13419 (Stop using transmute_mut in RefCell)
Closes #13417 (Remove an unnecessary file `src/libnative/io/p`.)
Closes #13409 (Closing assorted resolve bugs)
Closes #13406 (Generalized the pretty-print entry points to support `-o <file>`.)
Closes #13403 (test: Add a test for #7663)
Closes #13402 (rustdoc: Prune the paths that do not appear in the index.)
Closes #13396 (rustc: Remove absolute rpaths)
Closes #13371 (Rename ast::Purity and ast::Impure Function. Closes #7287)
Closes #13350 (collections: replace all ~[T] with Vec<T>.)
@huonw huonw deleted the devec-collections branch June 27, 2014 06:47
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 3, 2024
fix(clippy_lints/matches): wildcard_in_or_patterns will no longer be triggered for types annotated with #[nonexhaustive]

fixes rust-lang#13350

----

changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants