Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Fuchsia toolchain #134222

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bump Fuchsia toolchain #134222

wants to merge 2 commits into from
+5 −5

Conversation

steven807
Copy link
Contributor

try-job: dist-various-2

@rustbot
Copy link
Collaborator

rustbot commented Dec 12, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Kobzol (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Dec 12, 2024
@lqd
Copy link
Member

lqd commented Dec 12, 2024 •
edited
Loading

I wonder:

  • why another PR bump when Bump Fuchsia #134188 is still open and about to land? was it missing the other commit to build the toolchain/sdk?
  • why try builds on dist-various-2? it's not the fuchsia builder, so I won't do the try build yet

It'd be appreciated if some description was added to similar PRs in the future.

Actually I'll take this one r? lqd

@rustbot rustbot assigned lqd and unassigned Kobzol Dec 12, 2024
@steven807
Copy link
Contributor Author

This is an update to the Fuchsia SDK -- #134188 was updating Fuchsia itself.

Sorry for the lack of descriptions -- I'm new to the Fuchsia Rust Toolchain rotation, and this is the first time I've submitted these. I should have followed the structure in #123881 and #132294.

@lqd
Copy link
Member

lqd commented Dec 12, 2024

You don’t need to land both at the same time I presume?

@lqd
Copy link
Member

lqd commented Dec 12, 2024

What about the other question, do you need a try build for dist-various or the fuchsia builder?

@steven807
Copy link
Contributor Author

Correct, they did not need to be landed at the same time.

The bump-fuchsia commit was validated in the x86_64-fuchsia builder, but the instructions I have say to validate the bump-sdk PR using dist-various-2 (which does include a Fuchsia build). I'm not clear why our instructions suggest using the two different try-jobs for the two submissions.

@lqd
Copy link
Member

lqd commented Dec 12, 2024

Cool

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 12, 2024
@bors
Auto merge of rust-lang#134222 - steven807:bump_sdk, r=<try>
cc22916 
Bump Fuchsia toolchain

try-job: dist-various-2
@bors
Copy link
Contributor

bors commented Dec 12, 2024

⌛ Trying commit 06bf19b with merge cc22916...

@lqd
Copy link
Member

lqd commented Dec 12, 2024

If you were in https://github.com/rust-lang/team/blob/master/teams/fuchsia.toml you could run the try build yourself.

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Dec 12, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 12, 2024
@lqd
Copy link
Member

lqd commented Dec 13, 2024

No logs available on that failure, it could be spurious, let's @bors try

@bors
Copy link
Contributor

bors commented Dec 13, 2024

⌛ Trying commit 06bf19b with merge 14001ba...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 13, 2024
@bors
Auto merge of rust-lang#134222 - steven807:bump_sdk, r=<try>
14001ba 
Bump Fuchsia toolchain

try-job: dist-various-2
@bors
Copy link
Contributor

bors commented Dec 13, 2024

☀️ Try build successful - checks-actions
Build commit: 14001ba (14001ba42f76f7a940a48e066cf691f073922a0a)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lqd lqd

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@steven807 @rustbot @lqd @bors @rust-log-analyzer @Kobzol