Rollup of 8 pull requests #134292
Merged
Rollup of 8 pull requests #134292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider comments and bare delimiters the same as an "empty line" for purposes of hiding rendered code output of long multispans. This results in more aggressive shortening of rendered output without losing too much context, specially in `*.stderr` tests that have "hidden" comments.
…tiline span rendering
Signed-off-by: onur-ozkan <work@onurozkan.dev>
It is effectively a global resource and the jobserver::Client in Session was a clone of GLOBAL_CLIENT anyway.
It only exists to pass some information from one part of the driver to another part. We can directly pass this information to the function that needs it to reduce the amount of mutation of the Session.
It is treated as a map already. This is using FxIndexMap rather than UnordMap because the latter doesn't provide an api to pick a single value iff all values are equal, which each_linked_rlib depends on.
So that it becomes easy for a later commit to return `None`.
The test fails in this commit. The next commit fixes it.
A legitimate suggestion would be to change from
&raw const val
to
&raw mut val
But until we have figured out how to make that happen we should at least
stop suggesting invalid syntax.
Both paths are correct. This one's better.
Don't consider `///` and `//!` docstrings to be empty for the purposes of multiline span rendering.
Tweak multispan rendering to reduce output length Consider comments and bare delimiters the same as an "empty line" for purposes of hiding rendered code output of long multispans. This results in more aggressive shortening of rendered output without losing too much context, specially in `*.stderr` tests that have "hidden" comments. We do that check not only on the first 4 lines of the multispan, but now also on the previous to last line as well.
…youxu validate `--skip` and `--exclude` paths Fixes rust-lang#134198 cc ``@ChrisDenton``
…h, r=GuillaumeGomez rustdoc-search: fix mismatched path when parent re-exported twice
…iler-errors crashes: more tests v2 try-job: aarch64-apple try-job: x86_64-msvc try-job: x86_64-gnu
Only dist `llvm-objcopy` if llvm tools are enabled This uses the same condition that rust-lang#132720 added in the compilation phase. r? ``@jieyouxu``
…=jieyouxu
rustc_borrowck: Stop suggesting the invalid syntax `&mut raw const`
A legitimate suggestion would be to change from
&raw const val
to
&raw mut val
But until we have figured out how to make that happen we should at least
stop suggesting invalid syntax.
I recommend review commit-by-commit.
Part of rust-lang#127562
A bunch of cleanups (part 2) Just like rust-lang#133567 these were all found while looking at the respective code, but are not blocking any other changes I want to make in the short term.
…trochenkov Use a more precise span in placeholder_type_error_diag Closes: rust-lang#123861
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 4a204bebdf In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Dec 14, 2024
|
Finished benchmarking commit (a1740a9): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)Results (primary -5.7%, secondary -2.6%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResults (secondary 2.9%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 768.546s -> 769.058s (0.07%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
--skipand--excludepaths #134209 (validate--skipand--excludepaths)llvm-objcopyif llvm tools are enabled #134240 (Only distllvm-objcopyif llvm tools are enabled)&mut raw const#134244 (rustc_borrowck: Stop suggesting the invalid syntax&mut raw const)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup