Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed hashing of DefId for ty_enum. #13511

Merged
merged 1 commit into from
Apr 16, 2014
Merged

Conversation

Meyermagic
Copy link
Contributor

Fixes #13507.

I haven't familiarized myself with this part of the rust compiler, so hopefully there are no mistakes (despite the simplicity of the commit). It is also 5am.

@eddyb
Copy link
Member

eddyb commented Apr 14, 2014

Please put Fixes #13507 or Closes #13507 in the commit message if that is indeed the case.
Also, you need a test case - your original one shouldn't be hard to adapt to a cross-crate run-pass test.

Fixes hashing of DefId for ty_enum.

Adds tests for cross-crate TypeId equivalence for various types.
bors added a commit that referenced this pull request Apr 16, 2014
Fixes #13507.

I haven't familiarized myself with this part of the rust compiler, so hopefully there are no mistakes (despite the simplicity of the commit). It is also 5am.
@bors bors closed this Apr 16, 2014
@bors bors merged commit b9f7ac5 into rust-lang:master Apr 16, 2014
flip1995 pushed a commit to flip1995/rust that referenced this pull request Oct 18, 2024
`infinite_loop`: continuing an outer loop leaves the inner loop

changelog: [`infinite_loop`]: detect a `continue` targeting an outer loop

Fix rust-lang#13511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeId is sometimes not consistent across crates
4 participants