workcache: Don't assume gcc exists on all platforms #13546
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FreeBSD has recently moved to clang by default, and no longer ship gcc. Instead use "cc" on unix platforms (the default compiler) and "gcc" on windows.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 16, 2014
Closes rust-lang#13546 (workcache: Don't assume gcc exists on all platforms) Closes rust-lang#13545 (std: Remove pub use globs) Closes rust-lang#13530 (test: Un-ignore smallest-hello-world.rs) Closes rust-lang#13529 (std: Un-ignore some float tests on windows) Closes rust-lang#13528 (green: Add a helper macro for booting libgreen) Closes rust-lang#13526 (Remove RUST_LOG="::help" from the docs) Closes rust-lang#13524 (dist: Make Windows installer uninstall first. Closes rust-lang#9563) Closes rust-lang#13521 (Change AUTHORS section in the man pages) Closes rust-lang#13519 (Update GitHub's Rust projects page.) Closes rust-lang#13518 (mk: Change windows to install from stage2) Closes rust-lang#13516 (liburl doc: insert missing hyphen) Closes rust-lang#13514 (rustdoc: Better sorting criteria for searching.) Closes rust-lang#13512 (native: Fix a race in select()) Closes rust-lang#13506 (Use the unsigned integer types for bitwise intrinsics.) Closes rust-lang#13502 (Add a default impl for Set::is_superset)
|
Yikes. That's quite a brittle test. |
|
Is there any reason to keep workcache around? IIRC it was only used by rustpkg. |
|
I believe @erickt is using it in something, so it may still be useful, but perhaps not in the main repo. |
notriddle
pushed a commit
to notriddle/rust
that referenced
this pull request
Nov 10, 2022
Lower unsafety of fn pointer and fn item types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FreeBSD has recently moved to clang by default, and no longer ship gcc. Instead
use "cc" on unix platforms (the default compiler) and "gcc" on windows.