rustdoc: design fixes and changes #13776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrientetar
changed the title
adrientetar
changed the title
|
Updated the PR description. r? @alexcrichton |
|
This looks good to me, although I don't have a very large stake in this design. Does this look ok to those that have a stake in this? |
|
Those are just minor adjustments due to requests that I've seen a few times (bring back a slight grey background on code samples, decrease font-size, tighten margins). |
|
There was an issue in my cached pages' stylesheet, I fixed it. |
|
LGTM. The |
|
It would need to be bottom-aligned otherwise, which is a headache when using a float. – It can always be revisited later anyways. |
bors
added a commit
that referenced
this pull request
Apr 30, 2014
- Closes #13591. Relevant example: http://adrientetar.legtux.org/cached/rust-docs/struct.CChars.htm (Had to use `!important` to override CSS selector precedence, namely matching over parent class.) - Implement changes from #13780 feedback, namely: * Changed font-size from 18px to 15px * Reintroduced gray background for code samples * Tightened up the margins - Fix point 1 and point 4 of #13804. Samples: - [enum.FileType](http://adrientetar.legtux.org/cached/rust-docs/enum.FileType.htm) - [struct.CChars](http://adrientetar.legtux.org/cached/rust-docs/struct.CChars.htm) - [std](http://adrientetar.legtux.org/cached/rust-docs/std.htm) - [std::io](http://adrientetar.legtux.org/cached/rust-docs/io.htm). r? @brson
bors
added a commit
that referenced
this pull request
Apr 30, 2014
Two selector fixes for rustdoc: - links colored in blue (#13807) was also affecting headers, which are anchored to their respective ids - the header unstyling from #13776 was being applied to all headers also Additionally, remove a stray title in the documentation. This makes the crate title of prelude appear as header instead of an inline paragraph of text (all others work normally and do not have that header tag). The design is unchanged from my previous template (e.g. [here](http://adrientetar.legtux.org/cached/rust-docs/struct.CChars.htm)), however it is now properly applied. The last fix remaining is to enable webfonts service from `static.rust-lang.org`, this is #13593. r? @alexcrichton, @brson
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Dec 17, 2022
arcnmx
pushed a commit
to arcnmx/rust
that referenced
this pull request
Dec 17, 2022
fix: add a check for `if` token in patterns parser Closes rust-lang#13776
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Had to use
!importantto override CSS selector precedence, namely matching over parent class.)Samples:
r? @brson