rustc: Better resolve errors for *T, &T, &mut T, Box<T> #14265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis failure looks unrelated. |
| a; | ||
| //~^ ERROR: unresolved name `a`. Did you mean to call `BarTy::a`? | ||
| b; | ||
| //~^ ERROR: unresolved name `b`. Did you mean to call `self.b`? |
There was a problem hiding this comment.
These messages may not be necessary because you can't actually access self.b (*T doesn't auto-deref) (similarly for the other errors). The static method one is ok, but the others may end up just being misleading.
|
@alexcrichton Added an rpass test to confirm things build with the suggestions. Can remove if considered overkill or too difficult to keep synced going forward. (Would be kind of neat if we could have an |
bors
added a commit
that referenced
this pull request
May 20, 2014
This is hard coding `Box` into this, as it doesn't seem to parse as `TyUniq` like `~` did. This may not be correct for all usages of the box keyword. Closes #14254.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is hard coding
Boxinto this, as it doesn't seem to parse asTyUniqlike~did. This may not be correct for all usages of the box keyword.Closes #14254.