Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #14915 #14920

Closed
wants to merge 1 commit into from
Closed

Fix #14915 #14920

wants to merge 1 commit into from

Conversation

schmee
Copy link
Contributor

@schmee schmee commented Jun 15, 2014

No description provided.

@schmee
Copy link
Contributor Author

schmee commented Jun 16, 2014

@pcwalton r?

@schmee schmee deleted the remove-sigils branch June 21, 2014 10:07
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
@bors
Auto merge of rust-lang#14920 - lowr:fix/overhaul-named-struct-to-tup…
51c3ab5 
…le-struct, r=Veykril

Fix edits for `convert_named_struct_to_tuple_struct`

Two fixes:
- When replacing syntax nodes, macro files weren't taken into account. Edits were simply made for `node.syntax().text_range()`, which would be wrong range when `node` is inside a macro file.
- We do ancestor node traversal for every struct name reference to find record expressions/patterns to edit, but we didn't verify that expressions/patterns do actually refer to the struct we're operating on.

Best reviewed one commit at a time.

Fixes rust-lang#13780
Fixes rust-lang#14927
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schmee @alexcrichton