Hygiene for 3 kinds of args #15425
Merged
Hygiene for 3 kinds of args #15425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also, introduce fn_decl_arg_bindings and expand_and_rename abstractions
|
r=me with nit fixed |
|
Okay, nit fixed in aa91ef0 . |
bors
added a commit
that referenced
this pull request
Jul 5, 2014
…=cmr This pull request adds hygiene for 3 kinds of argument bindings: - arguments to item fns, - arguments to `ExprFnBlock`s, and - arguments to `ExprProc`s It also adds a bunch of unit tests, fixes a few macro uses to be non-capturing, and has a few cleanup items. local `make check` succeeds.
|
Does this close #9383? |
Closed
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 13, 2023
…ock, r=Veykril minor : Deunwrap convert_comment_block and desugar_doc_comment Closes subtask 13 of rust-lang#15398 . I still don't know a more idiomatic way for the for loops I added, any suggestion would make me happy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds hygiene for 3 kinds of argument bindings:
ExprFnBlocks, andExprProcsIt also adds a bunch of unit tests, fixes a few macro uses to be non-capturing, and has a few cleanup items.
local
make checksucceeds.