Port Rust to DragonFlyBSD #16073
Port Rust to DragonFlyBSD #16073
Conversation
Not included are two required patches: * LLVM: segmented stack support for DragonFly [1] * jemalloc: simple configure patches [1]: http://reviews.llvm.org/D4705
|
Neat! This basically looks good to me, and I'm glad that the patch itself is mostly straightforward. @alexcrichton should look too. It's unfortunate to add more 'cfg sprawl': it's already pretty messy and is only going to get worse. Both rust-lang/rfcs#185 (factoring out a platform abstraction layer specifically for the runtime) and rust-lang/rfcs#131 (flexible target specification) could help. @mneumann since you have fresh experience with porting Rust, if you have opinions about what would help porters, you might mention them on those bugs. |
|
I'm also glad to see that this didn't require too much platform-specific voodoo beyond plastering |
|
Hm, the travis build fails on |
Not included are two required patches: * LLVM: segmented stack support for DragonFly [1] * jemalloc: simple configure patches [1]: http://reviews.llvm.org/D4705
Replace `doc_comments_and_attrs` with `collect_attrs` fix rust-lang#16063 I looked at the other usages of `doc_comments_and_attrs` and it seems all of them are prone to ignoring inner attributes. `@Veykril` should I replace all of those with `collect_attrs` and remove `doc_comments_and_attrs` (or even `HasDocComments`) entirely?
Not included are two required patches: