Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

num: Fix the documentation of abs_sub. #16233

Merged
merged 1 commit into from
Aug 4, 2014
Merged

num: Fix the documentation of abs_sub. #16233

merged 1 commit into from
Aug 4, 2014

Conversation

omasanori
Copy link
Contributor

Use proper argument names and unbackquote the word "zero" because it is not an identifier.

Use proper argument names and unbackquote the word "zero" because it is
not an identifier.

Signed-off-by: OGINO Masanori <masanori.ogino@gmail.com>
@steveklabnik
Copy link
Member

r+=me

bors added a commit that referenced this pull request Aug 4, 2014
Use proper argument names and unbackquote the word "zero" because it is not an identifier.
@bors bors closed this Aug 4, 2014
@bors bors merged commit 3e6edee into rust-lang:master Aug 4, 2014
@omasanori omasanori deleted the abs_sub branch September 2, 2014 02:41
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 18, 2024
Implement `literal_from_str` for proc macro server

Closes rust-lang#16233

Todos and unanswered questions:

- [x] Is this the correct approach? Can both the legacy and `rust_analyzer_span` servers depend on the `syntax` crate?
- [ ] How should we handle suffixes for string literals? It doesn't seem like `rust-analyzer` preservers suffix information after parsing.
- [x] Why are the `expect` tests failing? Specifically `test_fn_like_macro_clone_literals`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants