Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the user to specify which asm syntax is desired for
--emit=asm
I also considered an environment variable to let it lurk under the covers a bit more but this seemed most optimal for a generic interface.
I asked on irc and didn't hear anything back so I figured I'd just go ahead and do it and amend if necessary. I was torn between a toplevel option and lurking it in behind
-Z
or similar.I have some concerns that would hold this back from being merged:
What does this do on arches that can't intel? (my intuition is thatHaven't tested on arm (rustc builds are /very/ expensive), but unless anyone objects I don't think this should block.llc
will barf horribly but I have no idea how rustc will deal with that)