Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local cache more often #18235

Merged
merged 2 commits into from
Oct 28, 2014
Merged

Use local cache more often #18235

merged 2 commits into from
Oct 28, 2014

Conversation

nikomatsakis
Copy link
Contributor

Use local cache when there are unbound type variables and where clauses are in scope.

Fixes #18209.

r? @nick29581

@nikomatsakis
Copy link
Contributor Author

cc @wycats

@dwrensha
Copy link
Contributor

Does this fix #18163 as well?

reference are not fully known. In that case, it may happen that the
trait selection process is also influencing type variables, so we have
to be able to not only cache the *result* of the selection process,
but *reply* its effects on the type variables.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'replay'?

@nrc
Copy link
Member

nrc commented Oct 22, 2014

r=me with an alias for uint

@nrc
Copy link
Member

nrc commented Oct 22, 2014

@dwrensha it should do, yes. Also #18187.

dwrensha added a commit to capnproto/capnproto-rust that referenced this pull request Oct 26, 2014
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Oct 27, 2014
@bors bors merged commit 4a8d712 into rust-lang:master Oct 28, 2014
@nikomatsakis nikomatsakis deleted the issue-18209 branch March 30, 2016 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression around Trait::method -> Self
5 participants