Assorted unboxed closure fixes #18337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Correctly categorize env pointer deref for `FnMut` as declared rather than inherited. This fixes an assert in borrowck. Closes rust-lang#18238 - Categorize env pointer deref as mutable only if the closure is `FnMut` *and* the original variable is declared mutable. This disallows capture-by-value `FnMut` closures from mutating captured variables that aren't declared mutable. This is a difference from the equivalent desugared code which would permit it, but it is consistent with the behavior of procs. Closes rust-lang#18335 - Avoid computing info about the env pointer if there isn't one.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 27, 2014
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Oct 22, 2024
fix: private items are shown in completions for modules in fn body Close: rust-lang#18287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The most substantial change here is that we disallow capture-by-value
FnMutclosures from mutating upvars that are not declaredmut, which is consistent with the behavior of procs and of other unboxed closure varieties, although it is notable that the equivalent desugaring would permit it since structure fields cannot have individual mutability.This also fixes an ICE, upvars sometimes not being marked as used mutably, and some bad diagnostic messages. There are still some improvements to be made here (#18330), but it's a longstanding issue that I'll try to address with a different PR.
Closes #18238
Closes #18335
Closes #18336
r? @pcwalton