Make BinaryHeap's Items iterator implement DoubleEnded and ExactSize #19330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: This commit will need to be rebased on top of #19176 when it lands, so I'll keep an eye on that. Just thought I'd throw it out there now. |
|
In retrospect, reverse iteration isn't a particularly semantically valid operation on a BinaryHeap. But I guess there's a partial order in there somewhere? Regardless, this is "free" to provide, and easy to remove later. |
|
It's my pleasure! Figured since you requested DoubleEnded etc. for MoveItems, I'd go back and add it for the other iterator as well since it's so simple. But it's totally fine if it gets pulled at some point! I'll try to get this rebased as soon as the iter stabilization lands. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 27, 2014
There's no reason that BinaryHeap's iterator can't implement DoubleEnded and ExactSize, so add these implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no reason that BinaryHeap's iterator can't implement DoubleEnded and ExactSize, so add these implementations.