Fix two invalid import cases #195
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If an import was unused we would never print any errors for it. * We would keep the existing environment in scope when descending 'foo.bar' and would find 'bar' in the global environment if there was no 'bar' in 'foo'.
|
Handled by the other pull req. Thanks. |
oli-obk
pushed a commit
to oli-obk/rust
that referenced
this pull request
Jul 19, 2017
Test the Rc::{into,from}_raw roundtrip
kazcw
pushed a commit
to kazcw/rust
that referenced
this pull request
Oct 23, 2018
* refactor the x86 module * document the i686 check * document strict and intel_sde feature * document nvptx module
dlrobertson
pushed a commit
to dlrobertson/rust
that referenced
this pull request
Nov 29, 2018
Add contributing document
djtech-dev
pushed a commit
to djtech-dev/rust
that referenced
this pull request
Dec 9, 2021
…ng_lot-0.11 Update parking_lot requirement from 0.10 to 0.11
matthiaskrgr
pushed a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 7, 2023
Split rustc tests in two
celinval
pushed a commit
to celinval/rust-dev
that referenced
this pull request
Jun 4, 2024
…#195) * Move `CurrentFnCtx` into its own file * Replace `GotocCtx` forwarding functions with a direct call to the `CurrentFnCtx` functions * Make all `CurrentFnCtx` fields private, with getters and setters.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately this fails for the imports in the use test. I should add parse-only and resolve-only flags to rustc, but for now it looked better to just comment those lines while the import support is finished.