std: Fully stabilize Option<T> #19849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit takes a second pass through the `std::option` module to fully stabilize any lingering methods inside of it. These items were made stable as-is * Some * None * as_mut * expect * unwrap * unwrap_or * unwrap_or_else * map * map_or * map_or_else * and_then * or_else * unwrap_or_default * Default implementation * FromIterator implementation * Copy implementation These items were made stable with modifications * iter - now returns a struct called Iter * iter_mut - now returns a struct called IterMut * into_iter - now returns a struct called IntoIter, Clone is never implemented This is a breaking change due to the modifications to the names of the iterator types returned. Code referencing the old names should updated to referencing the newer names instead. This is also a breaking change due to the fact that `IntoIter` no longer implements the `Clone` trait. These items were explicitly not stabilized * as_slice - waiting on indexing conventions * as_mut_slice - waiting on conventions with as_slice as well * cloned - the API was still just recently added * ok_or - API remains experimental * ok_or_else - API remains experimental [breaking-change]
| @@ -802,6 +801,66 @@ impl<A> DoubleEndedIterator<A> for Item<A> { | |||
|
|
|||
| impl<A> ExactSizeIterator<A> for Item<A> {} | |||
|
|
|||
| /// An iterator over a reference of the contained item in an Option. | |||
| #[stable] | |||
| pub struct Iter<'a, A: 'a> { inner: Item<&'a A> } | |||
There was a problem hiding this comment.
Isn't Item the "proper" name for this iterator according to the naming conventions RFC?
There was a problem hiding this comment.
Can't find the right RFC for it, if it exists, but this has always been @aturon's intention for the names to become.
There was a problem hiding this comment.
While Item used to be the conventional name, we've since tweaked the conventions so the name of the iterator returned should match the name of the method of iteration.
| @@ -761,20 +764,16 @@ impl<T> AsSlice<T> for Option<T> { | |||
| #[stable] | |||
| impl<T> Default for Option<T> { | |||
| #[inline] | |||
| #[stable] | |||
There was a problem hiding this comment.
Just FYI, I don't believe the stability attributes on methods in trait impls have any meaning.
There was a problem hiding this comment.
cc #14407 for why that doesn't warn.
bors
added a commit
that referenced
this pull request
Dec 16, 2014
std: Fully stabilize Option<T> Reviewed-by: aturon
bors
referenced
this pull request
Dec 16, 2014
Using a type alias for iterator implementations is fragile since this exposes the implementation to users of the iterator, and any changes could break existing code. This commit changes the iterators of `VecMap` to use proper new types, rather than type aliases. However, since it is fair-game to treat a type-alias as the aliased type, this is a: [breaking-change].
bors
added a commit
that referenced
this pull request
Dec 16, 2014
std: Fully stabilize Option<T> Reviewed-by: aturon
brson
added a commit
that referenced
this pull request
Dec 16, 2014
This commit takes a second pass through the `std::option` module to fully stabilize any lingering methods inside of it. These items were made stable as-is * Some * None * as_mut * expect * unwrap * unwrap_or * unwrap_or_else * map * map_or * map_or_else * and_then * or_else * unwrap_or_default * Default implementation * FromIterator implementation * Copy implementation These items were made stable with modifications * iter - now returns a struct called Iter * iter_mut - now returns a struct called IterMut * into_iter - now returns a struct called IntoIter, Clone is never implemented This is a breaking change due to the modifications to the names of the iterator types returned. Code referencing the old names should updated to referencing the newer names instead. This is also a breaking change due to the fact that `IntoIter` no longer implements the `Clone` trait. These items were explicitly not stabilized * as_slice - waiting on indexing conventions * as_mut_slice - waiting on conventions with as_slice as well * cloned - the API was still just recently added * ok_or - API remains experimental * ok_or_else - API remains experimental [breaking-change]
bors
added a commit
that referenced
this pull request
Dec 17, 2014
std: Fully stabilize Option<T> Reviewed-by: aturon
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 17, 2014
This commit takes a second pass through the `std::option` module to fully stabilize any lingering methods inside of it. These items were made stable as-is * Some * None * as_mut * expect * unwrap * unwrap_or * unwrap_or_else * map * map_or * map_or_else * and_then * or_else * unwrap_or_default * Default implementation * FromIterator implementation * Copy implementation These items were made stable with modifications * iter - now returns a struct called Iter * iter_mut - now returns a struct called IterMut * into_iter - now returns a struct called IntoIter, Clone is never implemented This is a breaking change due to the modifications to the names of the iterator types returned. Code referencing the old names should updated to referencing the newer names instead. This is also a breaking change due to the fact that `IntoIter` no longer implements the `Clone` trait. These items were explicitly not stabilized * as_slice - waiting on indexing conventions * as_mut_slice - waiting on conventions with as_slice as well * cloned - the API was still just recently added * ok_or - API remains experimental * ok_or_else - API remains experimental [breaking-change]
|
cc @jakub- |
|
err sorry, wrong PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit takes a second pass through the
std::optionmodule to fullystabilize any lingering methods inside of it.
These items were made stable as-is
These items were made stable with modifications
This is a breaking change due to the modifications to the names of the iterator
types returned. Code referencing the old names should updated to referencing the
newer names instead. This is also a breaking change due to the fact that
IntoIterno longer implements theClonetrait.These items were explicitly not stabilized
[breaking-change]