-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the new scheme for slicing #20562
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
r=me |
See PR #20576 <-- my attempt to get this landed while nick's asleep :) |
nrc
force-pushed
the
arrays-3
branch
5 times, most recently
from
January 5, 2015 22:46
9ab6c9a
to
9e66028
Compare
nrc
force-pushed
the
arrays-3
branch
3 times, most recently
from
January 6, 2015 03:39
61b061d
to
b2f46c5
Compare
bors
added a commit
that referenced
this pull request
Jan 6, 2015
Use index with ranges, rather than a dedicated trait and compiler support. This is not quite ready to land - it needs a rebase and a fair bit of work to pass make tidy. But I want to get it reviewed so I can try to land it quickly once it is rebased. This is how I expect things to look, in general.
🐎 |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 7, 2015
Merged as part of #20677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use index with ranges, rather than a dedicated trait and compiler support.
This is not quite ready to land - it needs a rebase and a fair bit of work to pass make tidy. But I want to get it reviewed so I can try to land it quickly once it is rebased. This is how I expect things to look, in general.