Add check to ensure trait bounds are only placed on ty_param #20623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs one slight fix, I realized I omitted another code path. |
jroesch
force-pushed
the
reject-non-param-bounds
branch
2 times, most recently
from
355a1bc to
9d56bcc
Compare
Add check to ensure trait bounds are only placed on ty_param
jroesch
force-pushed
the
reject-non-param-bounds
branch
from
9d56bcc to
b683e87
Compare
|
Waiting to ensure the error messages line up with the test run, but otherwise should be good to look over. @nikomatsakis |
|
So I'm giving this r+ though I think we should check the |
|
p=1 --> should land for alpha, not super critical |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 7, 2015
This closes rust-lang#20019, and should reject any where clauses placed on types not involving type parameters. r? @nikomatsakis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #20019, and should reject any where clauses placed on types not involving type parameters.
r? @nikomatsakis